Extended Character Stats

Extended Character Stats

8M Downloads

Incorrect Weapon Skill Calculation for Boss Hit Chance with Eye of Nerub

SirMAD86 opened this issue ยท 0 comments

commented

Bug description

This was reported on the WoW Classic Hunter Discord here with the +4 weapon skill Eye of Nerub.

Weapon skill hit rating is being incorrectly calculated for raid bosses with weapon skill below 305.

My understanding from reading it, is that it is with how the first +1 hit is ignored on raid bosses making the needed hit +9 instead of +8. There is something with how weapon skill is calculated below 305 vs raid bosses. The Eye of Nerub has +4 weapon skill, and might be the only piece in the game with less that +5 weapon skill.

According to this message it is roughly like this for a raid boss with 315 Defense:
301, 302, 303, and 304 worth .2% each
305 worth 1.2%
anything above 305 use formula 5 + (defenseValue - weaponSkill) * 0.1

A user posted a fix:

function DataUtils:GetMissChanceByDifference(weaponSkill, defenseValue)
    if (defenseValue - weaponSkill) <= 10 then
        return 5 + (defenseValue - weaponSkill) * 0.1
    else
        return min(8, 6 + (defenseValue - weaponSkill) * 0.2)
    end
end

Added Clause:

    local missChance = DataUtils:GetMissChanceByDifference(rangedWeaponSkill, enemyDefenseValue)
    local hitBonus = _GetRangeHitBonus()
    if rangedWeaponSkill < 305 and hitBonus >= 1 then
        hitBonus = hitBonus - 1
    end
    missChance = missChance - hitBonus

I would recommend reaching out to said discord group for any clarification.

Screenshots

Version

2.6.3