Issues with the Mission Control Screen after 8.1.5

Question

Issues with the Mission Control Screen after 8.1.5

missebet opened this issue 6 years ago · 12 comments

missebet commented 6 years ago

Please see attached screenshots, one with ElvUi on and one with ElvUi off.

LUA Error#1
Message: ...nterface\AddOns\GarrisonCommander\MissionControl.lua:402: CreateFrame(): Couldn't find inherited node "ItemButtonTemplate"
Time: Tue Mar 12 18:01:02 2019
Count: 1
Stack: ...nterface\AddOns\GarrisonCommander\MissionControl.lua:402: CreateFrame(): Couldn't find inherited node "ItemButtonTemplate"
[C]: in function CreateFrame' ...nterface\AddOns\GarrisonCommander\MissionControl.lua:402: in function <...nterface\AddOns\GarrisonCommander\MissionControl.lua:389> ...nterface\AddOns\GarrisonCommander\MissionControl.lua:842: in function BuildRewards'
...nterface\AddOns\GarrisonCommander\MissionControl.lua:582: in function <...nterface\AddOns\GarrisonCommander\MissionControl.lua:560>
(tail call): ?
(tail call): ?
[C]: ?
[string "safecall Dispatcher[1]"]:9: in function <[string "safecall Dispatcher[1]"]:5>
(tail call): ?
...nder\libs\LibInit\Ace3\AceAddon-3.0\AceAddon-3.0.lua:529: in function InitializeAddon' ...nder\libs\LibInit\Ace3\AceAddon-3.0\AceAddon-3.0.lua:644: in function <...nder\libs\LibInit\Ace3\AceAddon-3.0\AceAddon-3.0.lua:636> [C]: in function LoadAddOn'
Interface\FrameXML\UIParent.lua:446: in function UIParentLoadAddOn' Interface\FrameXML\UIParent.lua:636: in function Garrison_LoadUI'
Interface\FrameXML\UIParent.lua:1982: in function <Interface\FrameXML\UIParent.lua:1090>

Locals:

Error#2
Message: Interface\AddOns\GarrisonCommander\ShipControl.lua:456: CreateFrame(): Couldn't find inherited node "ItemButtonTemplate"
Time: Tue Mar 12 18:01:02 2019
Count: 1
Stack: Interface\AddOns\GarrisonCommander\ShipControl.lua:456: CreateFrame(): Couldn't find inherited node "ItemButtonTemplate"
[C]: in function CreateFrame' Interface\AddOns\GarrisonCommander\ShipControl.lua:456: in function <Interface\AddOns\GarrisonCommander\ShipControl.lua:442> Interface\AddOns\GarrisonCommander\ShipControl.lua:850: in function BuildRewards'
Interface\AddOns\GarrisonCommander\ShipControl.lua:636: in function <Interface\AddOns\GarrisonCommander\ShipControl.lua:614>
(tail call): ?
(tail call): ?
[C]: ?
[string "safecall Dispatcher[1]"]:9: in function <[string "safecall Dispatcher[1]"]:5>
(tail call): ?
...nder\libs\LibInit\Ace3\AceAddon-3.0\AceAddon-3.0.lua:529: in function InitializeAddon' ...nder\libs\LibInit\Ace3\AceAddon-3.0\AceAddon-3.0.lua:644: in function <...nder\libs\LibInit\Ace3\AceAddon-3.0\AceAddon-3.0.lua:636> [C]: in function LoadAddOn'
Interface\FrameXML\UIParent.lua:446: in function UIParentLoadAddOn' Interface\FrameXML\UIParent.lua:636: in function Garrison_LoadUI'
Interface\FrameXML\UIParent.lua:1982: in function <Interface\FrameXML\UIParent.lua:1090>

Locals:

Error#3
Message: ...rface\AddOns\GarrisonCommander\GarrisonCommander.lua:2367: attempt to index field 'startButton' (a nil value)
Time: Tue Mar 12 18:01:05 2019
Count: 1
Stack: ...rface\AddOns\GarrisonCommander\GarrisonCommander.lua:2367: attempt to index field 'startButton' (a nil value)
...rface\AddOns\GarrisonCommander\GarrisonCommander.lua:2367: in function `OpenMissionControlTab'
...rface\AddOns\GarrisonCommander\GarrisonCommander.lua:1548: in function <...rface\AddOns\GarrisonCommander\GarrisonCommander.lua:1548>

Locals: self =

{
IsFollowerUpgrade = defined @interface\AddOns\GarrisonCommander\Init.lua:241
ScriptGarrisonMissionFrame_OnShow = defined @interface\AddOns\GarrisonCommander\GarrisonCommander.lua:1723
ApplyMINXPLEVEL = defined @interface\AddOns\GarrisonCommander\MissionControl.lua:768
modules =

{
}
CancelTimer = defined @interface\AddOns\GarrisonCommander\libs\LibInit\Ace3\AceTimer-3.0\AceTimer-3.0.lua:145
OpenFollowersTab = defined @interface\AddOns\GarrisonCommander\GarrisonCommander.lua:2347
ApplyMAXRES = defined @interface\AddOns\GarrisonCommander\GarrisonCommander.lua:552
HookedGarrisonFollowerListButton_OnClick = defined @interface\AddOns\GarrisonCommander\GarrisonCommander.lua:1341
ApplyIXP = defined @interface\AddOns\GarrisonCommander\GarrisonCommander.lua:615
GarrisonMissionFrame_SelectTab = defined @interface\AddOns\GarrisonCommander\GarrisonCommander.lua:3139
DrawSingleButton = defined @interface\AddOns\GarrisonCommander\GarrisonCommander.lua:2776
AddFollowersToButton = defined @interface\AddOns\GarrisonCommander\GarrisonCommander.lua:3067
TestMissionExtra = defined @interface\AddOns\GarrisonCommander\MissionCache.lua:485
EventGARRISON_MISSION_STARTED = defined @interface\AddOns\GarrisonCommander\GarrisonCommander.lua:957
ScheduleTimer = defined @interface\AddOns\GarrisonCommander\libs\LibInit\Ace3\AceTimer-3.0\AceTimer-3.0.lua:92
ApplySGCSKIPEPIC = defined @interface\AddOns\GarrisonCommander\ShipControl.lua:774
GetMarketValue = defined @interface\AddOns\GarrisonCommander\MissionCache.lua:81
db =

{
}
SetEnabledState = defined @interface\AddOns\GarrisonCommander\libs\LibInit\Ace3\AceAddon-3.0\AceAddon-3.0.lua:455
MCMatchMaker = defined @interface\AddOns\GarrisonCommander\MatchMaker.lua:349
OpenProgressTab = defined @interface\AddOns\GarrisonCommander\GarrisonCommander.lua:2355
showdata = defined @interface\AddOns\GarrisonCommander\GarrisonCommander.lua:519
CleanUp = defined @interface\AddOns\GarrisonCommander\GarrisonCommander.lua:1914
ApplyGCSKIPRARE = defined @interface\AddOns\GarrisonCommander\MissionControl.lua:764
CreatePrivateDb = defined @interface\AddOns\GarrisonCommander\GarrisonCommander.lua:884
ApplyFOLLOWERMISSIONLIST = defined @interface\AddOns\GarrisonCommander\GarrisonCommander.lua:610
AddOptionToOptionsLayer = defined @interface\AddOns\GarrisonCommander\GarrisonCommander.lua:1099
Garrison_SortMissions_Class = defined @interface\AddOns\GarrisonCommander\GarrisonCommander.lua:361
UnregisterAllEvents = defined @interface\AddOns\GarrisonCommander\libs\LibInit\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:200
IsFollowerList = defined @interface\AddOns\GarrisonCommander\GarrisonCommander.lua:1271
RaiseCompleteDialog = defined @interface\AddOns\GarrisonCommander\GarrisonCommander.lua:1768
ApplyBIGSCREEN = defined @interface\AddOns\GarrisonCommander\GarrisonCommander.lua:576
shipyardDone = defined @interface\AddOns\GarrisonCommander\quick.lua:28
IsProgressMissionPage = defined @interface\AddOns\GarrisonCommander\GarrisonCommander.lua:1265
revision = "868da2e"
GetName = defined @int

alar77 · Answer 1 · 2019-03-15T10:57:16.000Z

I am not able to launch wow due to Wine issue, but I saw that blizzard removed ItemButtonTemplate and now there only is ItemButton wich is no longer virtual. Changing reference and uploading a beta.Can anyone test it?

Ludovicus-Maior · Answer 2 · 2019-03-15T11:03:50.000Z

I'll give it a test as soon as I see it.

Ludovicus-Maior · Answer 3 · 2019-03-15T12:59:28.000Z

AOK. Now downloading 3.0.1.Beta1

JimGiordano2 · Answer 4 · 2019-03-15T13:08:44.000Z

Just tried beta. Very little changed if anything.

Ludovicus-Maior · Answer 5 · 2019-03-15T13:36:21.000Z

I think the fix needs to be:

row= CreateFrame('ItemButton', "Priority" .. frameIndex, frame)

ItemButton is now a UI element, not a template.
Tested on the regular command table and shipyard.

alar77 · Answer 6 · 2019-03-15T13:49:20.000Z

AHA, this makes absolutely sense. I looked around for UI patch notes but could not find them. Cooking a beta2

alar77 · Answer 7 · 2019-03-15T13:54:40.000Z

Out 3.0.2.Beta2

Ludovicus-Maior · Answer 8 · 2019-03-15T14:04:48.000Z

Cool. Will test within the hour. I'm technically at work :-).

JimGiordano2 · Answer 9 · 2019-03-15T14:08:21.000Z

That seems to have worked! :)

Ludovicus-Maior · Answer 10 · 2019-03-15T14:41:51.000Z

Agreed! Looks good.
Both command tables now work.

alar77 · Answer 11 · 2019-03-15T15:05:09.000Z

So many thanks guys, tagging it as official release!

missebet · Answer 12 · 2019-03-15T15:26:50.000Z

TY for fixing this! Hugs to all you folks working on it.

Share to