Guildbook

Guildbook

860k Downloads

Enchanting recipe scanning is broken after code tidy commit (version 4.9832)

xbend opened this issue ยท 4 comments

commented

@stpain
Hey, I was investigating an issue with my guildbook not syncing new enchanting recipes after 4.9832.
According to my debugging, the bug was introduced with 40fb2bb

Core.lua Line: 1515
the condition if not englishProf then was mistakenly rewritten to if englishProf ~= false.
So if englishProf anything but false (like, for example "Enchanting") this new condition will be true ("Enchanting" is not equal to false) and the recipe scanning function will return.

Simply change that line to if englishProf == false and recipe scanning is back to normal.

I can PR the change myself if required.

commented

@stpain
Latest build fixed the issue (this commit preciselly: b3e1b45)

Cheers!

commented

image

i think i may have fixed this with my latest working version, th code looks different to last commit

commented

The issue I was pointing out is a different code section. Function function Character:ScanEnchantingRecipes():
Core lua
(My screenshot shows the code with my local fix applied already in the highlighted line)

Maybe your working code version modified it, but I was basing this issue on Core.lua in master branch.

commented

ah enchanting, that old nasty sorceress, the enchanting function should look almost the same as the other but uses the craft frame etc, will look into it in a mo