Suggestion/Permission

Question

Suggestion/Permission

Misunderstood-Wookiee opened this issue 6 years ago · 5 comments

Misunderstood-Wookiee commented 6 years ago

I sent you a msg on Curse unsure if you visit curse, essentially I queried and expressed interest in maintaining my own version of this on curse, and was hoping we may be able to come to an agreement.

Obviously, I do not intend to claim what is not my code or work. I also intended too fully kickback to this project so I thought maybe I could maintain my own version on curse which atm it is loaded in my addons and git as ImprovedBlizzardUIPlus, until such time as you decide to take it back over and I can always take down my version when it suits you.

I was just not sure if or when would want to make time to merge a PR or update curse and maybe it might be easier for both of us if I had a version going that people could use in meantime. I understand if no, or if you wanted to collab possibly have two flavours going on the original curse project that could be doable.

Let me know thoughts, as I am not sure if you would mind but I do need clarification via a response otherwise cures will reject my project as it is similar to yours and your licence does not allow derived works. Just to clarify I am not going to steal your work, I simply derived upon it and if you look over my git for the project you will see I mention you in as many ways as applicable and this project.

kaytotes · Answer 1 · 2018-12-16T22:20:16.000Z

@Misunderstood-Wookiee please take a look at #122

kaytotes · Answer 2 · 2018-10-02T14:25:40.000Z

I am just currently out for the day but will type up a full response this evening.

…

On Tue, 2 Oct 2018, 15:18 Misunderstood-Wookiee, ***@***.***> wrote: I sent you a msg on Curse unsure if you visit curse, essentially I queried and expressed interest in maintaining my own version of this on curse, and was hoping we may be able to come to an agreement. Obviously, I do not intend to claim what is not my code or work. I also intended too fully kickback to this project so I thought maybe I could maintain my own version on curse which atm it is loaded in my addons and git as ImprovedBlizzardUIPlus, until such time as you decide to take it back over and I can always take down my version when it suits you. I was just not sure if or when would want to make time to merge a PR or update curse and maybe it might be easier for both of us if I had a version going that people could use in meantime. I understand if no, or if you wanted to collab possibly have two flavours going on the original curse project that could be doable. Let me know thoughts, as I am not sure if you would mind but I do need clarification via a response otherwise cures will reject my project as it is similar to yours and your licence does not allow derived works. Just to clarify I am not going to steal your work, I simply derived upon it and if you look over my git for the project you will see I mention you in as many ways as applicable and this project. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#116>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHLaBqSL6f4J5T57dkVwu4urLB_8S4iLks5ug3WygaJpZM4XEIp7> .

Misunderstood-Wookiee · Answer 3 · 2018-10-02T15:51:34.000Z

No worries, I will maybe be sleep by then due to timezone differences, I operate under AU EST+10
trying to track down-a nill colour bug atm which rarely appears when finishing a pet battle have only see it once so far unsure of

another addon such as Pet Tracker or Collect Me is trying to write or change the same frame data or if the tooltip.lua is missing a catch to apply data.

What I can see is this Tooltop Lua Error.txt

and near the bottom, it is trying to set a nil colour for the pet frame I believe.

kaytotes · Answer 4 · 2018-10-05T20:17:23.000Z

Apologies for the very delayed reply, been hectic on my end and wanted to properly sit down and formulate a reply.

Your fork looks interesting and if you have any issues / fixes please feel free to PR them or open issues. While I am not currently actively playing I do for the most part still monitor things. I may return with 8.1 however can log in as a starter edition for most issues.

With regards to making your fork public as ImprovedBlizzardUIPlus I would take some issue with that and would not support it being uploaded to WoWInterface or Curse. This is because as I said above I will at some point be returning to the game at and continuing the project more actively however this is not considered abandoned.

I am curios about the changes that you have made. Do you have a list of them somewhere on your fork? Screenshots etc? If they're interesting additions I'd be very open to working in some form of collaboration with credit given which I have done for this UI in the past.

I am still maintaining the addon as well with regards to backporting to previous client versions, starting with Wrath of the Lich King and feel that could lead to further confusion too.

The terminology with issue #114 was important. Maintenance Mode not Abandoned.

I'm going to take a poke around in your fork as I'm very interested with what you have done.

Misunderstood-Wookiee · Answer 5 · 2018-10-06T04:46:04.000Z

No worries, the changelog everything mostly I keep it pretty tidy. Mainly just adjusted a few fonts and defaults to fit better into frames when the names exceed 14chrs. Split the font up into two fonts so it is possible to separate the UI from the chat style. Added the ability to hide everything in the main bar gfx wise. Guild default colour is calm lime-ish green to better match Blizzard default colour scheme, Fixed a major bug and I'm looking into implementing shared media lib so that fonts and textures can be pulled from a source (requires shared media addon to be installed on client separately but is not a dependant) in order for adding flexibility to extend to UI into themes in the future, (WeakAuras and details damage meter is a couple who use shared media lib when it's installed to extend the font and texture assets of the inbuilt.) But understand your reason for saying no that's okay. I'm just trying to learn how to make add-ons and I wanted to do some stuff with the UI and I been using this one for a while actually since I came back from leaving in Cataclysm I choose this as I hate the truly minimal ones such as ElvUI, though Azerite UI is shaping up to be a decent alternative to stock UI theme however right now it is very much in infancy stage as far as available data displayed goes. I have been extremely pleased with your UI work myself and my partner both use your UI and yea basically I loved it so much I wanted to fork it and have a fiddle so feel free to implement whichever you like I do try to keep features separated into commits so that if another or yourself would like to "cherrypick" a specific feature you may do so with just a simple merge of the cherry-picked commit relevant to that feature and u will not get any overlap between other changes. Though as you state in your infromation about the addon is configured for personal taste, my fork I have configured for what suits the blizzard ui and those coming too this addon I did want to maintain moving of frames and I do need too find a better solution too this so feel free to drop some advice as I would like to have them movable but still be set into pos to start with. I have not found a way to do this myself that does not cause the pos data to reset every reload. I was maybe considering implimenting a drop down for layout so you could say okay I want my frames to be in the stock pos, centered, top left, bottom right whatever and then run pos data based on which ever option you went with. User choice really, but overall I just wanted to try my hand at improving this for the fun of it and because when I get an idea which could be nice to have as an option I try and get it into this version so I can use it and then if you like you can just steal it from here. If you like what I am doing and want to collab on the same project in future that is cool, I can easily enough convert which ever I did for default into drop downs so every one gets a choice right now any new multi option feature I impliment will be via a drop down so personal choice is available rather than lock something into one state which is okay I mean you might not want to do the work for choices I can understand but I am happy too add frame pos data as a selectable choice for where the frames by are placed or if they are just unlockable, for example the unlocked movable frames could choice "custom pos" then u can unlock them but we would have to catch the lua error and hide it because having it come up when frame is not unlockable for some less savvy people will just presume addon is broken and will speak negatively about this UI however I think I have an idea on how we can capture and hide that. So decided I'd make adjustments to this and see how it goes.

…

On Sat., 6 Oct. 2018, 6:17 am Kaytotes, ***@***.***> wrote: Apologies for the very delayed reply, been hectic on my end and wanted to properly sit down and formulate a reply. Your fork looks interesting and if you have any issues / fixes please feel free to PR them or open issues. While I am not currently actively playing I do for the most part still monitor things. I may return with 8.1 however can log in as a starter edition for most issues. With regards to making your fork public as *ImprovedBlizzardUIPlus* I would take some issue with that and would not support it being uploaded to WoWInterface or Curse. This is because as I said above I will at some point be returning to the game at some point and continuing the project more actively however this is not considered abandoned. I am curios about the changes that you have made. Do you have a list of them somewhere on your fork? Screenshots etc? If they're interesting additions I'd be very open to working in some form of collaboration with credit given which I have done for this UI in the past. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#116 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AU-5Zwnai8O64smlwabJq6Vn1OxM3vJ4ks5uh75UgaJpZM4XEIp7> .

Share to