Improved Blizzard UI

Improved Blizzard UI

161k Downloads

Invalid LUA operation fix for Class Colours

Misunderstood-Wookiee opened this issue ยท 3 comments

commented

Misunderstood-Wookiee@86a2f37.

Sometimes the raid class colour cannot be found for the table during certain world events I noticed this during some pet battles and some during WOD intro scenarios while hovering over npcs nameplates.

For what ever the cause internally this does rarely occur and we have to give it some default data so that the table values are not nil which causes and invalid LUA operation for the function which gets class colours.

Above a commit made to my fork of this project that should fix the error by using a default table (white colour) whenever the initial raid class colour is not found.

commented

Thanks for this @Misunderstood-Wookiee I've pulled this in to what will be the latest build. 1bdc752

commented

@Misunderstood-Wookiee Fork this repo, cherry pick that commit and submit this as a PR? That's a decent sized chunk.

commented

I'll give a shot I'm not so great with PR or cherry picks. The repo I already did fork are you suggesting I fork it again and cherry pick my fork of that commit into his?