Improved Blizzard UI

Improved Blizzard UI

161k Downloads

ArtifactWatchBar

val1n opened this issue ยท 20 comments

commented

The ArtifactWatchBar gets repositioned but not resized. So it is far too long. Oh and the MultiBarBottomLeft and MultiBarBottomRight are overlapping the ArtifactWatchBar.

wowscrnshot_062016_130439

commented

Thanks for this. Will try my best to fix it up on the PTR but won't be able to properly test until I can get full Beta access.

commented

I will test it as good as i can (i have beta access) so if you need someone to test let us have a talk

commented

Since I have beta access as well, I would happily help you

commented

I'm currently at work so i can't test my first try to move the bar: https://github.com/ben2k1690/ImprovedBlizzardUI/tree/ArtifactWatchBar-Dev

Maybe if @val1n could try it?

commented

Occurs during combat. Seems to be only Honor related but I haven't quite yet tracked down exactly where in Blizzards code these are being reset.

#8 was the original issue but it seems to affect Honor, Rep and Artifact bars so I'll expand the issue once I get back home.

hooksecurefunc("MainMenuBar_UpdateExperienceBars", MainMenuBar_UpdateExperienceBars_Hook); corrects the issue once any of the bars are updated out of combat.

commented

Let me know if this is any better with 6f0143b on the development branch. Resetting still occurs in PvP combat but generally tweaked these bars.

commented

Just logged in and at fist it seems fine
wowscrnshot_062116_184150

commented

Hmm, looks like it's shunted up as if it's expecting either an Honor or Rep bar above the artifact bar. Maybe the artifact bar automatically shifts things upwards and I wasn't aware?

commented

The ArtifactWatchBar is centred. But the texture kept the original width. But just the texture .. to get the tooltip (and the text) I have to be in the 512 pixels. The left and right parts are just for deco. I mean I can see how much Artifact Power my weapon has, but as I said the tooltip will only be displayed in the 512 pixel range.
Oh and in the screenshot I have moved it 8 pixels ... and disabled the Bottom Left Bar
ModifyBasicFrame(ArtifactWatchBar, "TOP", nil, -256, 8, nil);

wowscrnshot_062116_140831

commented

It's a first step in the right direction.
I will try to get a custom bar when i am at home again. Currently at the work i'm not able to play the game :D

commented

Hold off a couple hours until I'm back from work. As soon as I get in I'll push my latest changes as I've considerably tweaked these bars. Still have an issue with them occasionally resetting during combat (Seems to be just PvP combat)

commented

In which way are they resetting? During combat or after combat when you gain ep/honor?

commented

#8 mentioned it. And since I have never experienced this, it seems that only PvP combat is affected by this.

commented

Considering this fixed with 01e886b

#8 still exists but it's a seperate issue.

commented

Feel free.

commented

it doesn't when you are not reposition it. I can put it a bit lower and test it if you want

commented

The Bars are just 10px to high. If you adjust them it fits perfectly
wowscrnshot_062116_185441

commented

It breaks on characters that have no exp bar or artifact bar. (Eg capped on PTR), would be fine once Legion arrives but now / after it will break again.

commented

Aight, pretty sure this covers all bases 2a9b9ab

I'll wait until I hear back from you guys before I close this and start looking into #8 again since it affects Rep, Honor, Artifact bars during PvP combat.

Edit: And by the way, this has been not perfect since WoD so if this all comes together i'll be happy haha.
Old ass screenshot

commented

I'm going to test it now

Edit: Looks perfect on the beta
wowscrnshot_062116_194104