Refresh button no longer does anything
9600bauds opened this issue · 4 comments
Describe the bug
Clicking the refresh button no longer does anything. This is only really noticeable if you manually disable or adjust the auto-refresh implemented in #161.
To Reproduce
Steps to reproduce the behavior:
- Adjust the auto-refresh timer to be slower, or disable auto-refresh entirely
- Press the refresh button
Expected behavior
It should refresh. It does not.
Desktop (please complete the following information):
3.12
@Vysci are familiar with what the button was supposed to do originally? i just assumed it was broken "clear all" button to reset the board to empty.
oh yea, it’s supposed to fetch entries from the dungeon tool in wotlk. To get data from the dungeon finder it requires a hardware event.
So it’s a wotlk thing. Code got more convoluted as SoM and SoD came out as all of the sudden and as I got lazier.
Oh okay, it had no tooltip i wasnt sure. Wotlk is sunsetting soon for Cata classic. Did you have any ideas as to what game versions you wanted to support going forward.
Well I think there is no reason to support anything past the base classic version anymore. However, I also said no reason to support anything earlier than wotlk and then SoD became a thing...
I don't see a need for this tool in cata or really wotlk anymore, tbc not a thing but can always just use an older version. We shall see when cata launches but would like to remove the code that deals with other expansions