Description
After making any change to options you must press Close in the bottom right hand corner. The changes will not be saved if you click another addon, close by pressing "X" in the top right, close by pressing escape.

To Reproduce
Steps to reproduce the behavior:

1. Click any setting checkbox (e.g. Lock minimap button position)
2. Close config or click away to another config screen
3. Open config. See that Lock minimap button position is unchecked.

Expected behavior
Any changes to a config option is expected to remain no matter how you close the window.

Desktop (please complete the following information):

• Version v3.11

Additional context
Season of Discovery

Re-opening this issue since the fix in #252 only affected the Dungeon/Raid filter settings panels.
The custom search patterns tab, for example, still requires a press of the close button.

(unless you tab to an expansion's filter tab and then close the settings via any manner to forces this hotfix's code)

@Vysci, I do have a fix planned and somewhat baked, but im taking the opportunity to clean up the LibGPIOptions.lua module.

fixed with closing #270 - #277.

Issue due to the OnCommit function for the setting panel is only called when the close button is pressed (this is blizzard intention). This commit function is where the addon used to verify all the settings changes and update the appropriate settings (saved variable values). see #269 for details

The internal state for these settings will not be updated as the settings are changed. In addition any setting in different areas that link to the same internal setting will now be synced.