LFG Group Bulletin Board

LFG Group Bulletin Board

5M Downloads

"Show a fixed number of request per dungeon" breaks "combine sub-dungeon" option

juemrami opened this issue ยท 1 comments

commented

Describe the bug
Its a couple of likely related bugs:

  1. The "combine" option is not respected when this option is enabled
  2. Dungeons are put into wrong categories when both options are enabled.
  3. If there are old saved variables with wotlk/tbc dungeon filters enabled, then the "fixed request" option will cause UpdateList to create a category header for these dungeons.
  4. Space created for entries even when no dungeon request exists when the "fixed request" option selected (this might be a feature, but it feels like a bug).

To Reproduce
Steps to reproduce the behavior:

  1. Enable Scarlet Monastery (or other combine-able dungeons)
  2. Enable "combine sub-dungeon" and "Show a fixed number of request per dungeon" options
  3. Open bulletin board.

Screenshots
(Bugs 1 & 2)
bug 1 & 2

(Bug 3)
3.1 3.2

(Bug 4)
bug 4

commented

@Vysci, there was also this behaviour that i was not sure about. This option always creates space for amount of entries you have set in the ShowOnlyNb variable.

Which looks like this (ShowOnlyNb == 5):
img1

The alternative is that ShowOnlyNb just acts as a limit for the amount of request to display per category, and no space is created for categories under the limit.

ie with ShowOnlyNb == 5
image