chat positioning

Question

chat positioning

swaagbagtag opened this issue 5 months ago · 7 comments

swaagbagtag commented 5 months ago

Describe the bug
so usually it will change LFG channel from what i have as /4 to /1 and general from /1 to /2 and trade from /2 to /3 or sometimes just wipe all channels completely

To Reproduce
Steps to reproduce the behavior:
No idea, log in and it is changed

Expected behavior
Channels to remain the same

Screenshots
not applicable

Desktop (please complete the following information):
all versions

juemrami · Answer 1 · 2024-06-12T00:45:03.000Z

Should be an easy fix, Ill implement it for the next release to prevent this issue going forward.

@swaagbagtag you're going to have to re-order manually in the chat settings to fix this. It doesnt make sense to implement a script to reorder every users channel list in a particular order as they may have adjusted the position of "LookingForGroup" to their preference.

juemrami · Answer 2 · 2024-06-12T00:29:01.000Z

Ive had this happen to me as well, but a while back i re-organized my channels in the wow chat settings.

And since then ive been unable to get the addon to reproduce this behavior.

From having looked at the code base the only thing that i think could cause this is when a new character is made and the code runs before they join any channels ever. But Ive not been able to reproduce with a fresh character either.

update:
I tested again on fresh characaters, and I've been able to consistently reproduce this on a new character if you just afk let some of the intro cutscene playout.

For some reason your character isnt connected to the blizzard channels (general/trade/defense) at the point that this addons code runs to join the official LFG channel.

Vysci · Answer 3 · 2024-06-12T01:46:57.000Z

The blizzard function for joining chat channels can be called before the chat channels or joined channels are available. This behavior additionally causes a raise condition with other addons that have you join channels. In the past I have tried to wait before all the chat channels are available before attempting to join but that still left the race condition against other addons to still happen. Didn’t spend more time to investigating

juemrami · Answer 4 · 2024-06-12T02:17:34.000Z

Its fine if other addon's dont bother waiting and mess up the users channel order, but i think its that we should at least wait.

The fix i drafted will join LFG as soon as any other channel is joined, including anything added by another addon.
If that happens, we can consider the users channel order to already be "corrupted" and they should report to whatever other addon theyre using that is joining channels before the officials channels have been joined.

Vysci · Answer 5 · 2024-06-12T03:04:24.000Z

While technically you are right, if it results in the issue happening 10x more frequently than it becomes a question of which addon do you like less cuz it’s time to disable it

juemrami · Answer 6 · 2024-06-12T03:47:27.000Z

Yea, i will change the code specifically check for either general or defense channels before attempting to join.
There is an API function i found when working on cata that has the pre-translated names for these channels so there shouldnt be any localization issues

juemrami · Answer 7 · 2024-06-18T23:02:14.000Z

Closing this with v3.31

If youre still having this issue after the update, do the following:

Go to the channel order settings (pictured in the original reply)
Leave "LookingForGroup" channel
Rejoin by clicking its button in the "Available Channels" section of the same settings.
Drag the LFG channel to where you want it to permanently be.

Remember, this is character specific.

Share to