Minimap button never stays in one place
shenaniganiz0r opened this issue · 5 comments
When I move the minimap button to the place I want it to stay and check the "lock the minimap button position" box, it never stays there. Upon re-logging or reloading UI, the button moves, sometimes to random spots. Unchecking the lock button position box yields the same result.
I would like the minimap button to stay in the place that I lock it, it gets tiresome having to move the button every time I log in. I'm running version 1.15.3, and the only other add-on I'm running that modifies the minimap is the Dragonflight UI Classic add-on.
Dragonflight UI Classic add-on.
Okay, ive downloaded and tested it and looked at the Dragonflight UI source.
It seems like their Addon was making up for ours not lining up well with LibDBIcon-1.0 icons because were still not using LibDBIcon (will likely move to it in the future).
The bug is coming from their patch, which overrides the saved positioning values via an early call to the onUpdate function during their patch initialization process when the game is loading. (this function is meant to be called when the button is being dragged).
The update function relies on your mouse position to determine the location of the button, so thats why it shows up on seemingly random locations, because your mouse is likely never in the same position every-time you reload your game.
Ive hotfixed our button to align better with the other LibDBIcon-1.0 icons now.
I can disable their patch by changing internal name of our minimap button.
I'll do that and release it as a beta/alpha release on CF for you while i open an issue with them so that they know they can remove their patch 👍
Wow, thank you so much for looking into this and giving a detailed response, that's amazing. 🫡
Yea np. Its up on curseforge as v3.37-beta1 if you wanna play with the fixed version @shenaniganiz0r
download here: https://legacy.curseforge.com/wow/addons/lfg-group-finder-bulletin-board/files/5648704
or via desktop app
Ive got a couple of more fixes to go into the release version of 3.37 so it wont be out soon.