LiteButtonAuras

LiteButtonAuras

Addons
20k Downloads

Switch to the new retail suggest ants/glow

mbattersby opened this issue · 3 comments

commented

Looks like the new (yellow) retail glow is taint free and could be used.

On one hand it's nice to be consistent with what they do. On the other hand all their new actionbutton spell effects are ... a bit much.

commented

With the code change in place to use the new flash.

1x [ADDON_ACTION_BLOCKED] AddOn 'LiteButtonAuras' tried to call the protected function 'SpellButton11:Enable()'.
[string "@!BugGrabber/BugGrabber.lua"]:481: in function <!BugGrabber/BugGrabber.lua:481>
[string "=[C]"]: in function `Enable'
[string "@FrameXML/SpellBookFrame.lua"]:901: in function `UpdateButton'
[string "@FrameXML/SpellBookFrame.lua"]:336: in function `SpellBookFrame_UpdateSpells'
[string "@FrameXML/SpellBookFrame.lua"]:1406: in function `SpellBook_UpdatePlayerTab'
[string "@FrameXML/SpellBookFrame.lua"]:14: in function `tabUpdate'
[string "@FrameXML/SpellBookFrame.lua"]:301: in function `SpellBookFrame_Update'
[string "@FrameXML/SpellBookFrame.lua"]:151: in function <FrameXML/SpellBookFrame.lua:142>

Locals:
_ = Frame {
 RegisterEvent = <function> defined @!BugGrabber/BugGrabber.lua:487
 0 = <userdata>
 UnregisterEvent = <function> defined @!BugGrabber/BugGrabber.lua:487
 SetScript = <function> defined @!BugGrabber/BugGrabber.lua:487
}
event = "ADDON_ACTION_BLOCKED"
events = <table> {
 ADDON_ACTION_BLOCKED = <function> defined @!BugGrabber/BugGrabber.lua:553
 ADDON_ACTION_FORBIDDEN = <function> defined @!BugGrabber/BugGrabber.lua:553
 PLAYER_LOGIN = <function> defined @!BugGrabber/BugGrabber.lua:547
 LUA_WARNING = <function> defined @!BugGrabber/BugGrabber.lua:562
 ADDON_LOADED = <function> defined @!BugGrabber/BugGrabber.lua:507
}

Hearthstoned to Valdrakken while in combat. May or may not be related to the change but posting it anyway.

commented

Definitely having this bug Stanzilla/WoWUIBugs#373 causing spellbook taint the first time you log in after starting the client. Depending on what else happens it can taint the ActionButtons as well afterwards. Dammit Blizzard!

  • 👀1
commented

In case you are watching, my code now looks like this because the start animation for the new glow was way too slow for something time critical like an interrupt:

function LiteButtonAurasOverlayMixin:ShowSuggestion(isShown)
    if isShown then
        -- Taken from ActionButton_ShowOverlayGlow(self) but we don't want the
        -- start animation because it takes 0.7s before the button starts to
        -- glow which is awful for time-sensitive things like interrupts (and
        -- in my opinion awful in general).
        ActionButton_SetupOverlayGlow(self)
        self.SpellActivationAlert.ProcStartFlipbook:SetAlpha(0)
        self.SpellActivationAlert.ProcLoop:Play()
        self.SpellActivationAlert:Show()
        -- LibBG.ShowOverlayGlow(self)
    else
        ActionButton_HideOverlayGlow(self)
        -- LibBG.HideOverlayGlow(self)
    end
end
  • 👍1