
[Bug] Stacks of the Weapon Embellishment "Ascendance" Show on the Shaman Ability "Ascendance"
Closed this issue ยท 6 comments
Took me a bit of testing to make sure I was looking at the right aura buff, since it's so short and gets shifted around, but I am fairly confident in saying that stacks of the weapon embellishment "Ascendance" show on the shaman ability "Ascendance", despite being completely unrelated.
The embellishment uses a different spellID for each stat randomly boosted:
Stat | ID |
---|---|
Critical Strike | 458502 |
Haste | 458503 |
Mastery | 458525 |
Versatility | 458524 |
What's weird is that it still shows after adding these 4 spell IDs to "Ignored Abilities".
(Sidenote: I hate that sometimes the buff is "Ascendance" and sometimes it's "Ascension". Blizzard WTH?)
This is not really a bug in the strict sense. It's more collateral damage for the fact that LBA is able to work at all.
LBA does all of its matching based on aura/spell names. There is no automatic way (even with data mining that I could see) to identify what ability spell ID causes what buff/debuff spell ID. The names usually match, the spell IDs sometimes match, and Blizzard are terrible at making anything neat (or have unique names) on their end.
In fact the whole existence of LBA is due to AdiButtonAuras trying to maintain an enormous set of buff-ability mapping data and getting two xpacs out of date and then expecting users to submit fixes.
So it is expected that if an aura name matches an ability name LBA will show it. There's no way for LBA to know otherwise. Like the description says: "It is like AdiButtonAuras, and Inline Aura before it, just much dumber".
It's also expected that adding them to ignored abilities did nothing, since it's strictly ignored ability spells that are on your bars, not ignored buff/debuff spells.
The right fix that isn't going to happen is Blizzard changing the names of the buffs so they aren't all called the same thing. You can add Ascendance (shaman ability, 114051) to the ignored spells and it won't match, but it also won't match the actual Ascendance which is kind of annoying.
I'll have a think about what if anything I should try to change in LBA for it. It's not clear if it's worth trying to maintain lists of exceptions, I might just end up back with AdiButtonAuras in an unmaintainable mess. I could add an "ignored buffs/debuffs" as well as ignored abilities, but people already don't understand how things work and I hate making things more complicated. I also don't want to break any behaviour people are relying on.
It's also expected that adding them to ignored abilities did nothing, since it's strictly ignored ability spells that are on your bars, not ignored buff/debuff spells.
Ah, now this is something I didn't know, and it makes sense now.
Looks like there isn't even just one Ascendance, the talent/spell ID is different per spec:
spec | ID |
---|---|
Elemental | 114050 |
Enhancement | 114051 |
Restoration | 114052 |
You can see why LBA is doing all its matching on name.
Ah, now this is something I didn't know, and it makes sense now.
This is one of the problems with humans, we see what we expect to see, especially when there are such confusing concepts as ability/buff/debuff/spell which are kind of all spells, but different. The text in the UI says "Ignored abilities" but nobody is guaranteed to understand "active ability spells on your bars" and yet that is the most clear wording I could come up with. Such is life.