Hi @Sellorio, are there any plans to continue development of this addon in Dragonflight? Asking to know whether it's feasible to port all my macros to your addon, while Dragonflight approaches quickly with the pre-patch.

It looks like blizz has to work on it themself, because if you make a macro without the addon you can't use the "hold to cast"-feature. So they are in trouble with their left click also.

First day of 10.0, and I see similar UI as jschick04's screenshot, but the old macro UI is not also visible.

More concerningly, all of my existing megamacros (on my actionbars) do nothing when clicked.

More concerningly, all of my existing megamacros (on my actionbars) do nothing when clicked.

Same here. Its not just the UI, the macro's themselves do not currently work.

I hope this can be fixed, because I rely heavily on mega macro and would hate to lose it.

One specific macro works!

		{
			["Scope"] = "gg",
			["Code"] = "#showtooltip\n/cast [button:1] Eternal Traveler's Hearthstone\n/stopmacro [button:1]\n/cast Revive Battle Pets\n/camp\n",
			["Id"] = 5,
			["StaticTexture"] = 134400,
			["ScopedIndex"] = 5,
			["DisplayName"] = "home",
		}, -- [13]

... sort of.

It does nothing if I left click it (intended to cast hearthstone and then /stopmacro), but it does log me out if I right-click it.

AFAICT none of my other macros work at all.

I've found similar issues discussed with other addons. It sounds like blizzard messed up how clicks are registered for the "SecureActionButtonTemplate" frame, which is what the macros are.

forum post: https://us.forums.blizzard.com/en/wow/t/dragonflight-click-bindings-broken/1361972/9
bug post: Stanzilla/WoWUIBugs#283

I'm done with wow for the foreseeable future and my only regret is not being able to continue maintaining this addon.

@aurelion314 if you'd be willing I'm happy to support you in updating the addon for 10.0. I am even happy to be in a call the whole time but I can't motivate myself to drive the development myself.

@Sellorio Can't blame you heh. I don't mind helping maintain it, but first need to figure out if this event bug is even fixable. I'm trying some hacks right now but haven't got anything to work..

More anecdata: all(?) of my macros behave correctly if I right-click them on my action bar. Left-click doesn't work. Pressing an assigned keybind doesn't work.

Hopefully dragonflight either doesn't modify any macro system code or has its own new macro ui. I suspect the former in which case ignoring out of date addons should work.

I don't have any plans to play dragonflight at this time.

If you or someone else can confirm that the addon works in dragonflight I'll bump the version so you don't have to tick that box just for me :P

I have tested it in DF and PTR and the addon itself seems to work but the issue is the MegaMacro UI doesn't get populated, and the old macro window still gets displayed.
And when I say it works, any existing macro still works but unable to edit the actual macro or create any new macros since the default UI only shows the MegaMacro code.

Looks like the new tabs ui is a breaking change. Wouldn't be surprised if it's not too hard to fix. Maybe i'll make a level 1 character to test fixes without buying dragonflight or subbing.

If it helps either of you this was posted by a user over on the curseforge page

errors since prepatch, only addons on (bugsack, buggrabber, mega macro):

1x ...e/AddOns/MegaMacro/src/windows/mega-macro.window.lua:229: attempt to index local 'buttonName' (a nil value)
[string "@Interface/AddOns/MegaMacro/src/windows/mega-macro.window.lua"]:229: in function <...e/AddOns/MegaMacro/src/windows/mega-macro.window.lua:208>
[string "@Interface/AddOns/MegaMacro/src/windows/mega-macro.window.lua"]:507: in function MegaMacro_ButtonContainer_OnShow' [string "*mega-macro.window.xml:192_OnShow"]:1: in function <[string "*mega-macro.window.xml:192_OnShow"]:1> [string "=[C]"]: in function Show'
[string "@Interface/FrameXML/UIParent.lua"]:2844: in function SetUIPanel' [string "@Interface/FrameXML/UIParent.lua"]:2687: in function ShowUIPanel'
[string "@Interface/FrameXML/UIParent.lua"]:2552: in function <Interface/FrameXML/UIParent.lua:2548>
[string "=[C]"]: in function SetAttribute' [string "@Interface/FrameXML/UIParent.lua"]:3150: in function ShowUIPanel'
[string "@Interface/AddOns/MegaMacro/src/windows/mega-macro.window.lua"]:407: in function Show' [string "@Interface/AddOns/MegaMacro/src/main.lua"]:27: in function ?'
[string "@Interface/FrameXML/ChatFrame.lua"]:5219: in function ChatEdit_ParseText' [string "@Interface/FrameXML/ChatFrame.lua"]:4883: in function ChatEdit_SendText'
[string "@Interface/FrameXML/ChatFrame.lua"]:4919: in function `ChatEdit_OnEnterPressed'
[string "*ChatFrame.xml:127_OnEnterPressed"]:1: in function <[string "*ChatFrame.xml:127_OnEnterPressed"]:1>

Locals:
items =

I can confirm the same behavior as @jschick04 found.. Was just a bit late to test this. I will update the issue title to make it a bug instead.

@Sellorio

Fix for keybinds/leftclick. Basically Left Click has to be explicitly declared now in he template macros that get written to the default macro storage

E:\World of Warcraft_retail_\Interface\AddOns\MegaMacro\src\engine\mega-macro-engine.lua
replace line 123
"/click [btn:1] "..ClickyFrameName..macroId.." \n"..

with
"/click [btn:1] "..ClickyFrameName..macroId.." LeftButton\n"..

Confirmed that the keybind/leftclick solution from @Dannez83 works!

I still can't edit macros, but being able to use my existing ones is a huge step forward!

Confirmed that the keybind/leftclick solution from @Dannez83 works!

I still can't edit macros, but being able to use my existing ones is a huge step forward!

starting on that now

hhah that's my post, I came here to post it but I see it's done already.

Hope you can maintain the addon, myself and a lot of players are quite dependent on it.

As mentioned there does seem to be a couple of different bugs. One to do with clicks/keybinds - which I think is a Blizzard issue, and one to do with the tabs ui. In addition to the above error, there are also the two below.

90x Interface/SharedXML/SharedUIPanelTemplates.lua:503: attempt to index field 'Text' (a nil value)
[string "@Interface/SharedXML/SharedUIPanelTemplates.lua"]:503: in function `PanelTemplates_TabResize'
[string "*mega-macro.window.xml:316_OnLoad"]:1: in function <[string "*mega-macro.window.xml:316_OnLoad"]:1>

Locals:
tab = MegaMacro_FrameTab1 {
 0 = <userdata>
}
padding = -8
absoluteSize = nil
minWidth = nil
maxWidth = nil
absoluteTextSize = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index field 'Text' (a nil value)"
TAB_SIDES_PADDING = 20

15x Interface/SharedXML/SharedUIPanelTemplates.lua:619: attempt to index field 'Left' (a nil value)
[string "@Interface/SharedXML/SharedUIPanelTemplates.lua"]:619: in function `PanelTemplates_SelectTab'
[string "@Interface/SharedXML/SharedUIPanelTemplates.lua"]:484: in function `PanelTemplates_UpdateTabs'
[string "@Interface/SharedXML/SharedUIPanelTemplates.lua"]:465: in function `PanelTemplates_SetTab'
[string "@Interface/AddOns/MegaMacro/src/windows/mega-macro.window.lua"]:452: in function `MegaMacro_Window_OnLoad'
[string "*mega-macro.window.xml:39_OnLoad"]:2: in function <[string "*mega-macro.window.xml:39_OnLoad"]:1>

Locals:
tab = MegaMacro_FrameTab1 {
 0 = <userdata>
}
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index field 'Left' (a nil value)"

I haven't done any addon dev for years, but I will have a go at this tonight/tomorrow as I seriously cannot live without this addon

@aurelion314 I've sent you an invite to the fork. I've got it to the point where all the tabs are appearing again. I believe what's stopping the macros showing up is related to the macro button that is used to add new macros.

fork is here for anyone else to download as well
https://github.com/Dannez83/mega-macro

@Dannez83 Awesome thanks, I'm at the same spot I think. My current error is also a buttonName issue, which might be related to how the xml error (after the inheritance errors) had a problem on the getName() line.

I'll try out your fork and see if its different.

Looks like they've changed some of the ui identifiers that are being inherited. Making progress

@Dannez83 awesome find! I was worried we'd have to wait for Blizzard.

Do you have a branch or fork that you're working on? I don't mind helping since I'm probably not alone in needing this to work before I can really enjoy anything in the new patch.

@Dannez83 awesome find! I was worried we'd have to wait for Blizzard.

Do you have a branch or fork that you're working on? I don't mind helping since I'm probably not alone in needing this to work before I can really enjoy anything in the new patch.

I hadn't set one up yet. Was going to do it if I fixed everything, but I'll happily set one up now and update with the changes I've made so far. Don't mind sharing the load

So where I'm at: The code assumes each macro button in the edit window has an Icon and Name frame to go along with it.

EX: _G['MegaMacro_MacroButton1']
It expects there to also be a _G['MegaMacro_MacroButton1Name'] and _G['MegaMacro_MacroButton1Icon'], which are frames that it tries to modify. Problem is they don't exists and I don't see where they are supposed to be set. My guess is that the old inherited frame "SimplePopupButtonTemplate" which has been replaced with "SelectorButtonTemplate", used to generate that automatically.

@Sellorio Do you recall where/how the Icon and Name frames get created? Or am I right that its a template thing? For context, The error is when you open the macro menu, and it tries to fill the macro icons but while the button frame exists, it can't set the name/icon.

@aurelion314 I've sent you an invite to the fork. I've got it to the point where all the tabs are appearing again. I believe what's stopping the macros showing up is related to the macro button that is used to add new macros.

fork is here for anyone else to download as well https://github.com/Dannez83/mega-macro

Thanks for putting in the work, there is no real way to start a conversation on your project and was hoping to ask about setting up a release for that project in a way I could download it via wowup

Bad: every macro in the other tabs [Class][Specialization][CharacterName][CharacterName Specialization] are gone, and the macros from these tabs on my bars which functioned (but couldn't be edited) before this update are now dead.

@durandal42 I pushed a version that shouldn't do that anymore. It also fixes icons, names, and hides one error I haven't fixed yet.

Get it here: https://github.com/Dannez83/mega-macro

Shift clicking on spells in the spell book does not work yet. Still trying to figure that out, but sharing what I have so far since it is at least functional and gets everyone their macros back.

Thanks for putting in the work, there is no real way to start a conversation on your project and was hoping to ask about setting up a release for that project in a way I could download it via wowup

The author of the addon is still active in this thread, so once its fully fixed I'm sure he'll approve it here. Then you can update it as normal. For now we are using that fork to work on it.

got it, thanks for the update

@Dannez83 I have it functional! It works (I can modify and rebind macros, and see icons), but I commented out a few things so the macro names are hidden. Will have to fix it properly but this is progress! I might have to go soon so if I don't get around to pushing to your fork, here is what I did:

1. Change line 44 from
   return _G[buttonName], _G[buttonName .. "Name"], _G[buttonName .. "Icon"]
   to
   return _G[buttonName], _G[buttonName .. "Name"], _G[buttonName].Icon
   (The Icon is a child of the button frame now, not its own global variable.)

2. Comment out any lines in the same file that use MegaMacro_FrameSelectedMacroButtonIcon
   (this is the editing macro icon. temporary fix just hides it)

That, along with the other changes you've already done, was enough to make it functional.

Really appreciate you guys working so hard on the addon. It's much appreciated.

@Dannez83 I have it functional! It works (I can modify and rebind macros, and see icons), but I commented out a few things so the macro names are hidden. Will have to fix it properly but this is progress! I might have to go soon so if I don't get around to pushing to your fork, here is what I did:

1. Change line 44 from
   return _G[buttonName], _G[buttonName .. "Name"], _G[buttonName .. "Icon"]
   to
   return _G[buttonName], _G[buttonName .. "Name"], _G[buttonName].Icon
   (The Icon is a child of the button frame now, not its own global variable.)
2. Comment out any lines in the same file that use MegaMacro_FrameSelectedMacroButtonIcon
   (this is the editing macro icon. temporary fix just hides it)

That, along with the other changes you've already done, was enough to make it functional.

Nice one @aurelion314. Well done. I'll update the fork
edit: is there anything else you changed as that's not working for me

@aurelion314 I think I've commented out everything needed but I'll leave it for you to update the fork just to be sure

is there anything else you changed as that's not working for me

After downloading the latest code from https://github.com/Dannez83/mega-macro and applying the fix from @aurelion314 above, I get tabs ([Global][Paladin][Protection][Lintilla][Lintilla Protecti...]) but only two icons appear, and it's the same two (in the same positions) in each tab.

I can't meaningfully interact with this window yet.

is there anything else you changed as that's not working for me

After downloading the latest code from https://github.com/Dannez83/mega-macro and applying the fix from @aurelion314 above, I get tabs ([Global][Paladin][Protection][Lintilla][Lintilla Protecti...]) but only two icons appear, and it's the same two (in the same positions) in each tab.

I can't meaningfully interact with this window yet.

I have updated with some additional lines commented out. Try downloading it again. It's in a working state now at least . The missing functionality is around icons and display names, but apart from that it will be at least functional

@Dannez83 @aurelion314 this is good stuff! Thanks for the updates. Don't forget to add credits to yourselves in the readme for updating the addon for Dragonflight when you're done. And once it's all done I'll accept the PR and upload it to curse (with credits there too).

Try downloading it again.

I'm confused; the last commit I can see here https://github.com/Dannez83/mega-macro/commits/master was ~3 hours ago, well before my most recent download (and then patch with @aurelion314's tweaks).

Try downloading it again.

I'm confused; the last commit I can see here https://github.com/Dannez83/mega-macro/commits/master was ~3 hours ago, well before my most recent download (and then patch with @aurelion314's tweaks).

sorry, in my rush to head off to bed I forgot to actually press the commit button. Done now

Good news and bad news:

Good: the latest commit has the [Global] tab working, and all the macros in there are editable and can be dragged onto action bars, where they then work.

Bad: every macro in the other tabs [Class][Specialization][CharacterName][CharacterName Specialization] are gone, and the macros from these tabs on my bars which functioned (but couldn't be edited) before this update are now dead.

So, for the time being, I'm reverting to the previous ~3 hours ago version, which is playable if not editable.

~3 hours ago version didn't fix it.

I've reverted all the way back to latest CurseForge version, and re-applied the fix from #158 (comment)

I also restored the copy of SavedVariables/MegaMacro.lua I made the night before 10.0, so I'm not sure whether the disappearance of my non-global macros was destructive.

Not working

i'm an idiot. never mind my question

Looks like something changed and now this change has to be reverted

E:\World of Warcraft_retail_\Interface\AddOns\MegaMacro\src\engine\mega-macro-engine.lua
replace line 123
"/click [btn:1] "..ClickyFrameName..macroId.." \n"..

with
"/click [btn:1] "..ClickyFrameName..macroId.." LeftButton\n"..

My macros are back, but couldn't be used by hotkey/left click etc... thoughts?

thanks a lot tho guys.

@jschick04 @tomleung0117

I just let my client update and it still works. Version 10.0.0.46313. It did multiple updates at once, so maybe they broke it only temporarily? Anyway if it still doesn't work, can you verify and share your client version?

@aurelion314

the verison i have is 8fdd7e (https://github.com/Dannez83/mega-macro) , which was uploaded 5hours ago. Is this the correct one ? not very familiar with git hub btw.. ty!

the verison i have is 8fdd7e (https://github.com/Dannez83/mega-macro) , which was uploaded 5hours ago. Is this the correct one ? not very familiar with git hub btw.. ty!

Yes that one is currently working for me.

just chiming in - macro icons etc load, can be editted and so on, but do not work with keybinds or click.
actionbar flashes as if bind is going through ,but no spells are cast

reverting this makes it appear to work

Looks like something changed and now this change has to be reverted

E:\World of Warcraft_retail_\Interface\AddOns\MegaMacro\src\engine\mega-macro-engine.lua
replace line 123
"/click [btn:1] "..ClickyFrameName..macroId.." \n"..

with
"/click [btn:1] "..ClickyFrameName..macroId.." LeftButton\n"..

"/click [btn:1] "..ClickyFrameName..macroId.." \n".. is the working line for me

yup it works for me too!

How do i use the Fork one? Do i have to manually change the lua files myself or can i copy/replace some files?

How do i use the Fork one? Do i have to manually change the lua files myself or can i copy/replace some files?

@gijsprins93 You have to replace the files with the forked files. Easiest to just replace everything.
Files are in World of Warcraft\_retail_\Interface\AddOns\MegaMacro

You may have to tweak one line as mentioned by wing5wong. Personally changing that line breaks it for me, so try the forked version first and see.

How do i use the Fork one? Do i have to manually change the lua files myself or can i copy/replace some files?

@gijsprins93 You have to replace the files with the forked files. Easiest to just replace everything. Files are in World of Warcraft\_retail_\Interface\AddOns\MegaMacro

You may have to tweak one line as mentioned by wing5wong. Personally changing that line breaks it for me, so try the forked version first and see.

But it won't let me download it anywhere tho.

Hello and ty for the updates. Quick question all the macro's are displayed as ? atm and not with their icons?!?
Before I updated it with the patches the macro's were showing with their icons just fine.

notice now the macro's actually don't work anymore after the patching and reinstalled the addon so I can at least use the macro's. Must have done something wrong patching.

Hello and ty for the updates. Quick question all the macro's are displayed as ? atm and not with their icons?!? Before I updated it with the patches the macro's were showing with their icons just fine.

notice now the macro's actually don't work anymore after the patching and reinstalled the addon so I can at least use the macro's. Must have done something wrong patching.

Best just to hang on for a bit. We're still working through a couple of bugs. Once done @Sellorio will push out the fix to addon sites

Just came back to see activity here. I'd like to thank everyone involved so far. I simply hope Blizzard will one day increase the limit of their macros and polish their whole macro system.

I did find an alternative to this in the Dominos Action Bars addon, as it has a feature called Paging, which can also be configured based on conditionals such as [harm]:

Thus, a combination between some simple macros and this Paging feature can actually replace the need to write macros longer than 255 characters.

Just came back to see activity here. I'd like to thank everyone involved so far. I simply hope Blizzard will one day increase the limit of their macros and polish their whole macro system.

I did find an alternative to this in the [Dominos Action Bars] addon, as it has a feature called Paging, which can also be configured based on conditionals such as [harm]:

Thus, a combination between some simple macros and this Paging feature can actually replace the need to write macros longer than 255 characters.

Dominos is no longer maintained addon, same goes with raven.

I don't see the connection between bar paging and macros, sorry :D

Dominos is no longer maintained addon, same goes with raven.

there is a community fix for raven. working good for me. check the comments on it's curseforge page

I don't see the connection between bar paging and macros, sorry :D

bartender4 has paging as well. it's what i ended up using for now to get things working. basically, as a druid anyway, i break my macros up into 3 or 4 separate macros and page to a new bar for humanoid/bear/cat.

that was my solution until either this or M6 is fixed.

My macros are back, but couldn't be used by hotkey/left click etc... thoughts?
thanks a lot tho guys.

Mine is doing the same thing. I can make new ones but when I add them to my action bar I cannot interact with it. Thank you for your time on this! I really appreciate it.

This line needs to be reverted back to the following

E:\World of Warcraft_retail_\Interface\AddOns\MegaMacro\src\engine\mega-macro-engine.lua
replace line 123
"/click [btn:1] "..ClickyFrameName..macroId.." \n"..

This line needs to be reverted back to the following

E:\World of Warcraft_retail_\Interface\AddOns\MegaMacro\src\engine\mega-macro-engine.lua replace line 123 "/click [btn:1] "..ClickyFrameName..macroId.." \n"..

My new fork fixes that and a bunch of other stuff: https://github.com/aurelion314/mega-macro

My macros are back, but couldn't be used by hotkey/left click etc... thoughts?

thanks a lot tho guys.

Mine is doing the same thing. I can make new ones but when I add them to my action bar I cannot interact with it.
Thank you for your time on this! I really appreciate it.

This line needs to be reverted back to the following
E:\World of Warcraft_retail_\Interface\AddOns\MegaMacro\src\engine\mega-macro-engine.lua replace line 123 "/click [btn:1] "..ClickyFrameName..macroId.." \n"..

My new fork fixes that and a bunch of other stuff: https://github.com/aurelion314/mega-macro

This works perfectly for me! Thank you very much!

@aurelion314 Do we need to download everything listed there, or just the SRC folder and MegaMacro.toc? I don't really understand GitHub

@aurelion314 Do we need to download everything listed there, or just the SRC folder and MegaMacro.toc? I don't really understand GitHub

Yep src folder and MegaMacro.toc is enough.

Yep src folder and MegaMacro.toc is enough.

Awesome! Thank you so much for the hard work fixing this. I use so many macros (especially mouseover for healing) and felt like I couldn't even play Pre-Patch because it was broken. Now I am very happily enjoying Pre-Patch!

Release incoming.

You can use /scripts/publish.bat to copy the relevant files to the right folder.

Awesome! Thank you so much for the hard work fixing this. I use so many macros (especially mouseover for healing) and felt like I couldn't even play Pre-Patch because it was broken. Now I am very happily enjoying Pre-Patch!

Glad I could help! I was in the exact same situation and almost didn't want to play.

@Sellorio Awesome! By the way, I added one more pull request that would be good to get into the release.

Release created! I'll close this off and we can make a new issue if there's any outstanding issues.

@aurelion314 @Dannez83 hot off the heels of your Dragonflight updating, if you're interested in adding WoW Classic or fixing ElvUI support then I'm sure there's a bunch of potential and current users that'll appreciate it. If not then that's completely understandable too - after all, I could never be bothered with that haha.

@Sellorio Sounds good! I'm glad everything was fixable since it's a great addon. And thanks for sticking around to push the release. It's nice when the original upload is kept current.

I don't play classic or use ElvUI so can't help there. Maybe someone else in here can give it a go.