MountsJournal

MountsJournal

294k Downloads

Error when ctrl clicking a collection item in a vendor window, etc.

nancikennedy opened this issue ยท 2 comments

commented

Environment

  • Addon version: 11.0.1
  • WoW version: 11.0.2

Steps to reproduce

Go to any vendor who sells mounts
Ctrl-Click on a mount in the vendor window

Expected Behaviour

Mount collection tab would open and show the mount in the relevant pane

Actual Behaviour

Did nothing and generated an error

1x ...rfaceMountsJournal/components/Hyperlinks.lua:20: attempt to call global 'IsAddOnLoaded' (a nil value)
[string "@MountsJournal/components/Hyperlinks.lua"]:20: in function <...rfaceMountsJournal/components/Hyperlinks.lua:4>
[string "=[C]"]: in function HandleModifiedItemClick' [string "@Blizzard_UIPanels_Game/Mainline/MerchantFrame.lua"]:645: in function OrigMerchantItemButton_OnModifiedClick'
[string "@BuyEmAll/BuyEmAll.lua"]:237: in function MerchantItemButton_OnModifiedClick' [string "@BuyEmAll/BuyEmAll.lua"]:45: in function MerchantItemButton_OnModifiedClick'
[string "*MerchantFrame.xml:33_OnClick"]:2: in function <[string "*MerchantFrame.xml:33_OnClick"]:1>

Locals:
link = "|cffa335ee|Hitem:46814::::::::70:70::14::1:28:872:::::|h[Sunreaver Dragonhawk]|h|r"
config =

{
waterJump = true
useHerbMounts = true
useDefaultJournal = false
noPetInRaid = true
coloredMountNames = true
useRepairFlyableDurability = 31
gridToggle = false
journalWidth = 865.461548
filterToggle = true
summonPetEvery = false
useUnderlightAngler = true
modifier = "NONE"
noPetInGroup = true
herbMountsOnZones = true
copyMountTarget = false
useRepairMounts = true
journalHeight = 876.769287
openHyperlinks = true
wowheadLinkLang = "en"
summonPetEveryN = 5
useMagicBroom = true
summonPetOnlyFavorites = false
repairSelectedMount = 61447
useRepairMountsDurability = 41
mountDescriptionToggle = true
camera =
{
}
arrowButtonsBrowse = true
useRepairFlyable = true
useRepairFreeSlotsNum = 1
macrosConfig =
{
}
showWowheadLink = true
autoUseUnderlightAngler = true
}
_ = ""
_ = "cffa335ee"
_ = ""
linkType = "item"
linkID = "46814"
mountID = 330
(*temporary) = nil
(*temporary) = "Blizzard_Collections"
(*temporary) = "attempt to call global 'IsAddOnLoaded' (a nil value)"
ns =
{
familyDB =
{
}
specificDB =
{
}
mountsDB =
{
}
calendar =
{
}
newMounts =
{
}
journal = MountsJournalFrame {
}
additionalMounts =
{
}
binding = MountsJournalBinding {
}
config = MountsJournalConfig {
}
pets = Frame {
}
aboutConfig = MountsJournalConfigAbout {
}
classConfig = MountsJournalConfigClasses {
}
L =
{
}
util =
{
}
mounts = MountsJournal {
}
}

commented

In my local copy, I was able to fix the error and restore the expected functionality by changing lines 20/21 in Hyperlinks.lua to:
if not C_AddOns.IsAddOnLoaded("Blizzard_Collections") then
C_AddOns.LoadAddOn("Blizzard_Collections")

These two API functions now require the new naming convention. This happened some time ago but I forgot about it until I was testing addons after yesterday's patch.

commented

Hi, thx you for the feedback, fixed :)