Myslot

Myslot

Addons
4M Downloads

[Bug+Fix] - Non base spells not being recognized

hewozuoai opened this issue · 1 comments

commented

Noticed this on a evoker.

For example;

Dream Breath (Spell ID: 355936) when talented for Font of Magic (Preservation) changes the spell ID to 382614.

I did some testing...

IsSpellKnown(382614) # false
IsSpellKnownOrOverridesKnown(382614) # true
C_Spell.PickupSpell(355936) # works
C_Spell.PickupSpell(382614) # doesn't work
FindBaseSpellByID(382614) # 355936

Can we add a further fallback option before

myslot/Myslot.lua

Line 754 in d600639

- something like;

                        -- another fallback option - try to get base spell
                        if not GetCursorInfo() then
                            local baseSpellId = FindBaseSpellByID(index)
                            if baseSpellId then
                                PickupSpell(baseSpellId)
                            end
                        end

I tested this locally and it works :)

commented

sure
could you please send a pr?

  • 👍1