Plater Nameplates

Plater Nameplates

Addons
64M Downloads

Sticky Interact CVar issue

Yakehira opened this issue ยท 5 comments

commented

In my own addon Better Fishing i set CVars dynamically, but if a user decides to fish and /reload while doing so this will cause some quirk in plater as it checks for the cvar.

See: https://github.com/Tercioo/Plater-Nameplates/blame/2496475939a05df2907291e1f50a66fcfcc7b0ad/options/Plater_O_Advanced.lua#L194

Easy repro

  1. Go to Advanced settings in plater and make sure this is off.
    image

  2. /run SetCVar("SoftTargetInteract", 3)

  3. /reload

  4. Check in the wow Settings if Enable Interact Key is enabled, it will not be!

  5. /reload again

  6. Check again in settings, Enable Interact Key is now turned on, as well as in Plater is now sticky

  7. If a user decides to turn off Enable Interact Key over the Settings rather than plater now, it will never properly work unless disabled over plater or plater being disabled.

image

commented

Goddamn blizzard not honoring their own names... You are likely right about the case sensitivity. I'll likely need to migrate the whole storage to lowercase instead this case, which sucks.

commented

The recently released changes should improve the setting to no longer be sticky.

commented

Remains being very sticky and can only be toggled in plater settings, toggling it in the Default UI doesn't appear to work.

Root of the cause seems to be

Plater-Nameplates/Plater.lua

Line 1536 in 2496475

elseif cvars_to_store [cvar] then
which is case sensitive, but it needs to be entirely case-insensitive, the settings write softTargetInteract, not SoftTargetInteract.

commented

This should ensure it is recognized properly.

commented

Yeah that appears to work now properly, thanks :)