In combat doesnt work against training dummies
greym0uth opened this issue ยท 2 comments
Game and Plater version
Plater: 9.0.1.309-retail
WoW: 9.0.1
Describe the bug
-
Steps to Reproduce (what did you do to make the bug happen):
Set in combat healthbar size different from out of combat. -
Result (what happens when you follow the steps above):
When entering combat with a training dummy, the nameplate state does not change. -
Expected (what you think the expected behavior would be when following the steps:
Healthbar should be using in combat sizing/profile settings. -
When the bug started (a date, wow path release, details update, etc)?
After 9.0.1.307-retail update (happened with this 67d3a27#diff-1db561366533fc606b39c5b02911293cbfd0ef25cb949792a0ff1f2ea1df9887R11). -
Additional information:
This works for units who can change their state to in combat but since training dummies are never in combat this doesn't work. I primarily use training dummies to test my profile settings. I have a fork (https://github.com/Jaden-Giordano/Plater-Nameplates/tree/jg/global-combat-toggle) currently that adds a checkbox to the general settings to toggle this new logic, but I see there y'all have been changes to try to fix (4951f09). If you want to take a look at my work and let me know if its something I should make a PR with.
Training dummies do not have a combat state, they are always out of combat.
Plater checks the combat state of the unit, not the player.
This is expected behavior until blizzard decides that dummies will be in combat as well.
Can we add a setting to disable this for testing purposes? I have a fork with that option being added https://github.com/Jaden-Giordano/Plater-Nameplates/tree/jg/global-combat-toggle. Should I just open a PR?