Newcomers chat mentor and murloc icons
artazika opened this issue · 13 comments
Describe the bug
Before the update, mentor and murloc text was hidden, only the icon was visible
To Reproduce
Steps to reproduce the behavior:
- Write anything in chat for newbies with mentor status or wait until someone writes
- You can see the icon and text
Expected behavior
Expected to see only icons without text
Screenshots
Version Information (please complete the following information):
- Wow Version:
[1]="10.0.0",
[2]="46455",
[3]="Nov 1 2022",
[4]=100000 - Prat Version:
[1]="Prat |cff8080ff3.0|r (|cff8080ff3.9.5|r)"
Addons you are running
Large list of addons. I disabled them all, left only the right and still see this bug
This was changed in #44
I also would like it to behave like it used to be until recently - only show the icons.
Also a bug likely coming from #44 too and I think it's worth mentioning here is that I can see myself as a guide now when in a dungeon group, which I'm pretty sure should not happen outside of the Newcommer Chat
while being in a mythic+ group
I wrote the original implementation of this. The check that's removed in #44 is what is causing it. That condition sets it to only show guide flags to newcomers and murlocs to guides.
The original implementation directly mirrored blizzard's implementation, which appears to have changed (see lines 3518-3533 of ChatFrame.lua for more details)
edit:
On a personal note, I too really don't like seeing guide next to my name on literally every message. If there's insistence on changing this, can an option be added to toggle it? Thanks a bunch :)
The original implementation directly mirrored blizzard's implementation, which appears to have changed (see [lines 3518-3533]
Can you explain a little, here? How was the original implementation in Prat? What has changed in the original blizzard file? And do you mean that it changed in 10.0 in blizz file?
I have not used default chat, I've been using Chatter for retail for many years and when they added the newcommer chat and I became a guide I remember only seeing icons for new plyares/guides. When I switched over to Prat (rip Chatter), I remember it had the same behavior - only showing icons. It's just with 10.0 that it changed (guide icon no longer shown) and then with one of the alpha versions it got changed to show the icon+text for guides.
This is a small issue overall, I could live with any choices tbh, but I was wondering how it was, what changed on Blizz side etc. Ofcourse, ideally the user would have configurable options in Prat settings for (show icon for new players; show text for new players; show icon for guides; show text for guides), but not sure if this is easy to implement or not.
I've now set it to follow Blizzard behaviour in the newest alpha, with converting it to options on my todo list:
- Mentor flag visible if you are in newcomers chat and a mentor or anytime any chat if you're a new newcomer
- Murloc visible if you are a mentor and the newcomer is in any chat.
The original implementation directly mirrored blizzard's implementation, which appears to have changed (see [lines 3518-3533]
Can you explain a little, here? How was the original implementation in Prat? What has changed in the original blizzard file? And do you mean that it changed in 10.0 in blizz file?
Sorry for the confusion. By original implementation, I mean I'm the one who wrote the new comer / mentor behavior for prat initially back in BFA. In 8.3 on release Blizzard's code only showed you the opposite flag from your status (see ChatFrame.lua). In 9.0.5 they changed this (see ChatFrame.lua) behavior to show you other guides in newcomer chat.
I have not used default chat, I've been using Chatter for retail for many years and when they added the newcommer chat and I became a guide I remember only seeing icons for new plyares/guides. When I switched over to Prat (rip Chatter), I remember it had the same behavior - only showing icons. It's just with 10.0 that it changed (guide icon no longer shown) and then with one of the alpha versions it got changed to show the icon+text for guides.
Prat was using the exact same logic Blizzard used originally. Prat uses the value of NPEV2_CHAT_USER_TAG_GUIDE . The reason you just noticed it was that #44 made the guide status visible to other guides. Chatter must have manually implemented just the guide icon.
I've now set it to follow Blizzard behaviour in the newest alpha, with converting it to options on my todo list:
- Mentor flag visible if you are in newcomers chat and a mentor or anytime any chat if you're a new newcomer
- Murloc visible if you are a mentor and the newcomer is in any chat.
@plusmouse Thanks!
Mentor does not appear in other chats other than the newcomers chat, but is still displayed "guide" as text near the icon with Prat-3.0-3.9.6-4-g029096b
Hi. Its been a while, but I'm finally at the options on my todo list. What options are wanted?
- Guide icon only (no label) in newcomers chat
- Guide icon and label in newcomers chat
- No guide icon or label in newcomers chat
- Murloc icon in newcomers chat if guide
- Murloc icon in newcomers chat if newbie
Hi. Its been a while, but I'm finally at the options on my todo list. What options are wanted?
- Guide icon only (no label) in newcomers chat
- Guide icon and label in newcomers chat
- No guide icon or label in newcomers chat
- Murloc icon in newcomers chat if guide
- Murloc icon in newcomers chat if newbie
Would these be individually toggle-able? Or just select one of them?
For example, I'd wish to see "Guide icon and label in newcomers chat" + "Murloc icon in newcomers chat if guide"
I was thinking of having a few sets of settings
- Murloc icon on and off in newcomers chat
- Murloc icon on and off in not-newcomers chat
- Guide icon and label on and off in newcomers chat (with a subsetting to remove the label)
