Glow Execute button in all stances
ennvina opened this issue ยท 1 comments
Currently, the Execute button glows when the game client tells that the ability is ready. For example, it will only glow in the Battle and Berserker Stance.
Many warriors would like to see the proc in other stances as well, even if they would need to stance dance to benefit from the proc.
This will require an option
- the current behavior will be the default behavior, which matches what the game client wants us to do
- the new behavior will be an option, so that experienced players can play around stance dancing
Execute button glows if these conditions are met:
- the warrior can attack its current target
- the target has less than 20% health
- the target has more than 0 health, to prevent triggers from dead bodies
The first condition is done by calling UnitCanAttack. It is unsure what happens if the enemy is hostile but all attacks would miss e.g., banished or cycloned. It shouldn't make a huge difference, but if it is too annoying, please file an issue.
The latter condition may trigger false negatives with hunters who Feign Death. If this happens, please file an issue, although fixing it might be a pain.
Execute button stops glowing if either condition is met:
- the target gets heals to 20% health or more
- the warrior clears its target (i.e., target nothing)
- the warrior targets a new target that cannot be attacked, or does not meet health conditions (between 0 and 20% health), or both