SpellActivationOverlay

SpellActivationOverlay

3M Downloads

Lingering Alerts

ennvina opened this issue ยท 1 comments

commented

It seems that Spell Alerts may stay for longer than expected if an aura fades during a loading screen.

There are several ways to fix this:

  • implement #57 (maybe with a shorter duration e.g., 20-30 seconds after leaving combat)
  • register events triggered by loading screen, and check if buffs are lost
  • upon activation, each aura starts a ticker (e.g. every 2 seconds) and check if aura is still here

The first solution is arguably the best one, because it fixes naturally the issue, without a dedicated code to maintain.

commented

Fixed in #76.

The chosen solution was mostly the second one:

register events triggered by loading screen, and check if buffs are lost

Please read the Pull Request details or more information.

The first solution was insufficient, because it would only cover issues with SAOs, not issues with GABs.

The third solution would have probably caused a lot of trouble, cf. PR details which showcases some major issues.