Sushi-3.1

Sushi-3.1

1.5k Downloads

Drop:IsMouseInteracting Attempt to access forbidden object

Gnarfoz opened this issue ยท 1 comments

commented

I'm getting this error with the latest version of PetTracker (which includes Sushi-3.1), on WoW 9.0.1:

13x ...PetTracker\libs\Sushi-3.1-4\classes\drops\Dropdown.lua:148: Attempt to access forbidden object from code tainted by an AddOn
[string "=[C]"]: in function `IsMouseOver'
[string "@PetTracker\libs\Sushi-3.1-4\classes\drops\Dropdown.lua"]:148: in function <...PetTracker\libs\Sushi-3.1\classes\drops\Dropdown.lua:147>
[string "@PetTracker\libs\Sushi-3.1-4\classes\drops\Dropdown.lua"]:153: in function <...PetTracker\libs\Sushi-3.1\classes\drops\Dropdown.lua:147>
[string "=(tail call)"]: ?
[string "@PetTracker\libs\Sushi-3.1-4\classes\drops\Dropdown.lua"]:93: in function <...PetTracker\libs\Sushi-3.1\classes\drops\Dropdown.lua:92>

Locals:
(*temporary) = SimpleCheckout {
 0 = <userdata>
 RightOutside = <unnamed> {
 }
 RightInside = <unnamed> {
 }
 Background = <unnamed> {
 }
 CalculateDesiredSize = <function> defined @Blizzard_StoreUI\Blizzard_SimpleCheckout.lua:101
 OnShow = <function> defined @Blizzard_StoreUI\Blizzard_SimpleCheckout.lua:54
 OnLoad = <function> defined @Blizzard_StoreUI\Blizzard_SimpleCheckout.lua:25
 OnHide = <function> defined @Blizzard_StoreUI\Blizzard_SimpleCheckout.lua:61
 LeftOutside = <unnamed> {
 }
 OnExternalLink = <function> defined @Blizzard_StoreUI\Blizzard_SimpleCheckout.lua:83
 TopInside = <unnamed> {
 }
 BottomOutside = <unnamed> {
 }
 CloseButton = <unnamed> {
 }
 TopOutside = <unnamed> {
 }
 BottomInside = <unnamed> {
 }
 OnEvent = <function> defined @Blizzard_StoreUI\Blizzard_SimpleCheckout.lua:29
 LeftInside = <unnamed> {
 }
 RecalculateSize = <function> defined @Blizzard_StoreUI\Blizzard_SimpleCheckout.lua:139
 OnRequestNewSize = <function> defined @Blizzard_StoreUI\Blizzard_SimpleCheckout.lua:75
}

I'm not sure what SimpleCheckout even is, apparently part of the store UI.
I think the offending function needs an frame:IsForbidden() check on line 148: https://github.com/Jaliborc/Sushi-3.1/blob/master/classes/drops/Dropdown.lua#L148
And presumably on line 152 as well: https://github.com/Jaliborc/Sushi-3.1/blob/master/classes/drops/Dropdown.lua#L152
(https://wow.gamepedia.com/API_UIObject_IsForbidden)

commented

Good idea!