Talent Loadout Manager

Talent Loadout Manager

83.4k Downloads

Append talents to /simc output instead of inserting

seriallos opened this issue ยท 3 comments

commented

FYI, I made some changes on Raidbots in the last year or so that provide less dire warnings when text is appended to /simc exports rather than when the body of the export is modified. If you append the loadouts after the #checksum line, folks will see the following:

Image

Rather than the more severe version:

Image

Would you consider appending with that warning in place or do you think your users would reject it? I can also change the style a bit more to minimize the scary factor to see if we can find a point that gets it right.

commented

Hm, interesting.. I'll give it a ponder for sure

on one hand, I feel like addon generated additions are on a different level than manual editing
on the other hand, I can also understand if you/raidbots want to keep a clear distinction between official addon output and "plugins"

The original red error/warning was a definite dealbreaker, but making it a yellow warning makes it a lot better
I'm half wondering whether it would make sense to more officially support addon provided additions, though tbh I think there's at most a handful addons where that'd make sense

I'll give it some more thought today, but initially I think I'm fine either way, though I don't feel much incentive to make changes

Do you have any specific reason for asking? ๐Ÿ™‚

commented

It came up in the Raidbots Discord: https://discord.com/channels/260172135023116288/1095785121954680843/1345246776742907996

Sounds like there might be an issue right now - unclear if it's the SimC addon, TLM, or something else. I don't think I've made any changes that would break your approach but I've only taken a cursory look so far.

I agree that it would be ideal for the SimC addon to be able to integrate with other addons for cases like this. The reality is that feature additions to the addon are pretty low on my priority list and I'm not actually much of a Lua developer so it's pretty far outside my wheel house. I've made a backlog item to look into it some more but who knows if I'll get to it.

commented

Thanks for the link, I see what's going on and why

For now I'll just fix the issue, I'm happy to work with you to add some form of plugin system to the simc addon (though honestly I don't know if it's worth the effort for either of us ๐Ÿ™‚)