Talent Loadout Manager

Talent Loadout Manager

83.4k Downloads

Unable to import from wowhead import codes

kientran opened this issue ยท 7 comments

commented

I have been unable to import talent builds from Wowhead import codes on their role guides.

  1. Clicking on the Copy Build button on wowhead provides the import string.
  2. In game open up Talent panel and select top level build to import into
  3. Click "Import" button, past import string.
  4. Provide name
  5. Clicking "Import" button has no effect or provides no information about the issue.

Import strings are valid as they can be imported to blizzard UI directly.

commented

yeah the wowhead build is wrong, and wouldn't be something you'd get from ingame
the correct build string is CYEAAAAAAAAAAAAAAAAAAAAAAAAAAYAAamltZmtltxYbMz22MbAAAAAAY00MMMzYbGMbDjZbGbDDmhhlF2AAAIzMtNLz2MAgNgBAjxMMD rather than
CYEAAAAAAAAAAAAAAAAAAAAAAAAAAYAAamltZmtltxYbMz22MbAAAAAAY00MMMzYbGMbDjZbGbDDmhZsswGAAAZmptZZ2mBAsBMAYMmhZA
I might see if I can add some sanity check to deal with wowhead building wrong loadout strings

commented

actually there's a small-ish change that allows you to import and likely won't break anything, so I'll throw that in a release in a minute

commented

please check if you're on the latest version and add an example, I tried a build and it worked fine on my end
installing buggrabber and bugsack if you don't have them can help to see if there's any lua error

commented

interesting, I'll look into it, I can reproduce that error

commented

Deleted all and reinstalled.

Here's an example

Ret Paladin Raid Cleave

CYEAAAAAAAAAAAAAAAAAAAAAAAAAAYAAamltZmtltxYbMz22MbAAAAAAY00MMMzYbGMbDjZbGbDDmhZsswGAAAZmptZZ2mBAsBMAYMmhZA

Looks like there was a bugsack error that was hidden among some other ones

47x ...eTweaks/libs/LibTalentTree-1.0-27/LibTalentTree-1.0.lua:446: entryID must be a number
[C]: in function 'assert'
[TalentTreeTweaks/libs/LibTalentTree-1.0-27/LibTalentTree-1.0.lua]:446: in function 'GetEntryInfo'
[TalentLoadoutManager/core/ImportExportV2.lua]:97: in function <TalentLoadoutManager/core/ImportExportV2.lua:56>
[tail call]: ?
[TalentLoadoutManager/core/ManagerApi.lua]:213: in function 'UpdateCustomLoadoutWithImportString'
[TalentLoadoutManager/modules/DefaultUISidebar.lua]:91: in function 'DoImportIntoCurrent'
[TalentLoadoutManager/modules/SideBarMixin.lua]:425: in function <TalentLoadoutManager/modules/SideBarMixin.lua:414>
[tail call]: ?
[Blizzard_SharedXML/Mainline/SharedUIPanelTemplates.lua]:1090: in function <...izzard_SharedXML/Mainline/SharedUIPanelTemplates.lua:1086>

Locals:
(*temporary) = false
(*temporary) = "entryID must be a number"

Looks like this is specific to a specific ret tallent listed in the Raid and M+ builds. The delve's build actually worked. Still trying to work out what talent it is specifically

commented

Appears to be working. Odd that the bad string works on the native import. Thanks for the help!

commented

The native import explicitly checks for and ignores bad data in the string (and I'm doing pretty much the same now)