[REQ]Interface increment the version number
nanjuekaien1 opened this issue · 19 comments
What is the feature you would like requested?
There is a proposal, and DBM can display the version number on the same interface
I don't really understand what you want.
Have the interface number in the version number? I see no reason to do that. It's properly document in the toc https://github.com/dfherr/ThreatClassic2/blob/master/ThreatClassic2.toc
@dfherr Because after the recent upgrade of version 2.2, some players can’t see the hate list, I can only ask them what version they are. After correcting their opinions based on the version, I found that many people don’t know the version number they installed. Thought, can you show the version number somewhere on the interface.
When you login you get a print out of the current version in chat. I can also add a /tc2 version command to print it again.
I had two reports of problems with the threat list, but no one could give me any errors 🤷 so I can't reproduce them
@dfherr There are more than two. In CN, I received 4 responses. If there is no error report, I cannot see the hate list. I told them to use version 2.19.
@dfherr By the way, DBM removed support for LibThreatClassic2 library files.
address： https://github.com/DeadlyBossMods/DBM-Classic/commit/1cd3b0f87c8a6ae8664ce35d644cd5e372d147b4
@dfherr There are more than two. In CN, I received 4 responses. If there is no error report, I cannot see the hate list. I told them to use version 2.19.
Version 2.19 will stop working with patch 1.13.5 (coming July 28th in the west). Version 2.20 is prepared for the new patch (it no longer needs LibThreatClassic2) and conditionally loads the threat API if available. Maybe the Chinese WoW client is different and already implements the api, but does not return anything yet? Then this problem might occur.
What does the following command print on a chinese client:
/run if _G.UnitThreatSituation ~= nil then print("api available") else print("api not available") end
For the EU client it prints api not available and everything works as expected.
@dfherr I also returned [18:18:26] api not available 。
The problem is, my version 2.2 is fine to see everyone's threat value.
@dfherr There is another thing I forgot to say， Can restore the function of nameplates.
If they have some other addon installed that sets UnitThreatSituation or UnitDetailedThreatSituation globally, then tc2 will stop to work with the changes from version 2.20. However, this would be the fault of the other addon.
@dfherr There is another thing I forgot to say， Can restore the function of nameplates.
nameplates were no longer working correctly with the new threat api.
there are some good nameplate addons that provide this functionality:
https://www.curseforge.com/wow/addons/plater-nameplates
https://www.curseforge.com/wow/addons/threat-plates-classic
I think tidy plates and neatplates work too:
https://www.curseforge.com/wow/addons/neatplates
neatplates also has a theme to look like default: https://www.curseforge.com/wow/addons/neat-plates-blizzardplates
@dfherr Okay, back to me, I told them that the plug-in package I integrated with the name board hate function.
@dfherr Thank you。
@dfherr Okay, back to me, I told them that the plug-in package I integrated with the name board hate function.
what xD? could you elaborate? you added a plug-in and that set UnitDetailedThreatSituation and caused the issue? Or is this about the nameplates?
@dfherr Tell them nameplates were no longer working correctly with the new threat api.
@dfherr I am using NDuiClassic
address：https://github.com/siweia/NDuiClassic
@dfherr You may find that the problem is there, and some people have installed ClassicThreatMeter。
They have left ClassicThreatMeter in the integrated plug-in. I don’t know if it’s his relationship.
ClassicThreatMeter should be uninstalled under all circumstances. It causes major trouble with addon communication. Blizzard added additional restrictions which makes the issue even worse.
As ThreatClassic2 will use the API from patch 1.13.5 onwards it will no longer be impacted. But keeping ClassicThreatMeter installed still impacts things such as incoming heal display, debuff durations of other players, etc.