Total RP 3

Total RP 3

4M Downloads

Improve Markdown parser: ignore text between `backticks`

Ellypse opened this issue · 4 comments

commented

What steps will reproduce the problem?

Enter Markdown text in a field in Total RP 3 that accepts Markdown (dashboard, about part of the profile) and use the backticks ` to indicate a block of code.

What is the expected output? What do you see instead?

The text inside the block of code should not be interpreted by any of Total RP 3's interpreter.
Right now, the text is interpreted, and Total RP 3 tags are rendered.

Side note

You all know how bad I am with regex, so I'm leaving this here in case someone wants to help on this :)

commented

I'm already knee-deep in doing validation stuff so I'll look at this.

commented

I'll try and wrap this one up over the weekend as I'm settling on a design that I finally like. My one question is do we only want to ignore ``` (three backtick blocks) or single-ones (`some inline text!`) as well?

I imagine some people somewhere could already have lone backticks in their profile and it'd be a bit weird if one day they updated and had something like Anna smacked Elsa around the face with a satsifying `whack!` have one of its words disappear.

commented

Hmm. I do need single backticks for inline code blocks in the changelogs and maybe some other parts of the UI, but you have a point about the existing texts.

Maybe we will make the backticks parsing optional, pass an argument to ask for it, and we will give it true for the changelogs and when we know we want full Markdown syntax.

commented

I'm fine with that idea.