Total RP 3

Total RP 3

Addons
4M Downloads

"New update available" pop-up points to non-existent setting to disable it

whisperity opened this issue ยท 0 comments

commented

Describe the issue

When the local version is outdated, a pop-up eventually (after some synchronisation) appears about the addon version being too old. It says this can be disabled, but the option to disable can not be found:

Image

Expected behaviour

Do not show the details about how to disable the warning if the ability to disable it had been removed earlier. Or reintroduce the ability to disable it.

Issue checklist

Please select any applicable options from the below list.

  • The issue occurs with the latest version of the addon.
    • This claim is fundamentally impossible to discertain.
  • The issue occurs with Total RP 3 as the only enabled addon.
  • The issue occurs only with other addon(s) enabled (please provide a list).

Steps to reproduce

Give us a list of steps to reproduce the issue with.

  1. Have an older version of the add-on installed. I tried with 3.0.5.
  2. Log in while others are also playing on the server.
  3. Wait about 5 seconds after opening TRP window for the warning to appear.

Additional information

It should appear in the latest version as well. As of commit b04c588, the message and the usage in code is still present:

Total-RP-3/totalRP3/Locales/enUS.lua

Line 1249 in b04c588

NEW_VERSION = "|cff00ff00A new version of Total RP 3 (v %s) is available.\n\n|cffffff00We strongly encourage you to stay up-to-date.|r\n\nThis message will only appear once per session and can be disabled in the settings (General settings => Miscellaneous).",

Total-RP-3/totalRP3/Modules/Register/Main/RegisterExchange.lua

Lines 265 to 277 in b04c588

-- Test for Total RP 3
if senderVersion > Globals.version and not has_seen_update_alert then
if Utils.table.size(newVersionAlerts[senderVersionText]) >= 10 then
local newVersionAlert = loc.NEW_VERSION:format(senderVersionText:sub(1, 15));
local numberOfVersionsBehind = senderVersion - Globals.version;
if numberOfVersionsBehind > 3 then
newVersionAlert = newVersionAlert .. "\n\n" .. loc.NEW_VERSION_BEHIND:format(numberOfVersionsBehind)
end
TRP3_UpdateFrame.popup.text:SetText(newVersionAlert);
TRP3_UpdateFrame:Show();
has_seen_update_alert = true;
end
end

Notice how checkVersion() or its 2 usage points do not contain any indication of checking whether the user disabled these alerts.