Total RP 3

Total RP 3

4M Downloads

Map markers for characters not using the right icon

Solanya opened this issue ยท 2 comments

commented

What steps will reproduce the problem?

Scan for player stashes in Stormwind, then scan for characters.

What is the expected output? What do you see instead?

Expected : a lot of points
Instead : a bunch of points and a bunch of stash icons (Extended stash icons are broken, disregard the style)
image

Did you try having Total RP 3 as the only enabled addon and everything else (especially something like ElvUI) disabled?

Obviously not without Extended, disabled everything else

What version of Total RP 3 are you using?

1.3.4.1

Was it working in a previous version? If yes, which was the last good one?

No clue when it last worked, but fairly sure it did at some point.

commented

Technically it's an extended bug coupled with the change I made for coloring the blips.

I'd changed the map blip decoration code from using SetTexture plus hardcoded constants for the texcoords to using Blizzard's texture atlasing system, which effectively maps a fixed string to a texture/texcoord pair.

In extended you're plugging in pure texture coordinates without ever changing out the texture.

There's a list of atlas mappings extracted with some black magic sorcery here.

This causes issues because before TRP was using Interface\Minimap\ObjectIcons.blp as the texture and the coordinates were relative to that, but the atlas stuff now actually maps to Interface\Minimap\ObjectIconsAtlas.blp, which has wildly different texcoords.

Extended is mostly at fault here however because it wasn't explicitly setting the texture at any point, so it should have broken in a similar way should the map have recycled a point that previously belonged to a HOUSE decoration type. The scan marker decorator callback should either set marker.iconAtlas to an atlas which maps to the correct icon you're trying to display, or you can cheat and just add in a marker.icon:SetTexture() call.

TLDR; Extended makes the assumption that the marker.icon texture is Interface\Minimap\ObjectIcons.blp. Naughty. Go fix.

commented

I figured it was due to your changes but couldn't understand where it was going wrong. That should actually make it much easier to fix, thanks ^^