Total RP 3

Total RP 3

4M Downloads

NPC talk detection prefix tooltip states non-EMOTE channels are supported

Meorawr opened this issue ยท 1 comments

commented

The chat frame code for detecting NPC talk only works on the EMOTE channel despite what our tooltip says for the NPC talk detection pattern setting.

if event == "CHAT_MSG_EMOTE" then

CO_CHAT_MAIN_NPC_PREFIX_TT = "If a chat line said in SAY, EMOTE, GROUP or RAID channel begins with this prefix, it will be interpreted as an NPC chat.\n\n|cff00ff00By default : \"|| \"\n(without the \" and with a space after the pipe)",

This has been broken for ~4 years as part of what looks like a rewrite of the chat frame code in e6a60c2. Either it was broken unintentionally or the tooltip text wasn't updated to account for the change - either way one of them needs correcting.

commented

This change was intentional as supporting SAY would be difficult for "headless" emotes, such as /say | The snow glows white on the mountain tonight.. For EMOTE we replace the character name by the first word, so The here, which makes it clickable. If we were to do the same for SAY it would appear as [The]: snow glows white, or worse with possible chat addons installed (Like [The:60:Group 2]: snow glows white.

EMOTE is the only channel that will not format the messages in such way.