WoW-Pro Guides

WoW-Pro Guides

3M Downloads

Comment lines within the guide section of the lua

kristjin opened this issue ยท 11 comments

commented

with a > or ; or something

Cheers!

commented

Agreed. Will add at some point, though moving = busy atm :D

commented

How about adding a ';' step that ignores the rest of the line?

Sounds like a harmless things for a first time for me to try.

Jiyambi?

commented

; is used for other things in the code so that symbol won't work, but another one might do the job. I seem to remember trying this once and having it totally not work at all, and then not working on it further because I got distracted by other features.

If anyone would like to try working this into the parser, I'd be pleased to add it into the main code if it seems to work well!

commented

OK. I'll try "#" or ";". I presume the correct thing to do is then push the changes?
How do I resolve the Feature/Issue?

commented

Uhh... why don't we just use normal Lua comments with a -- prefix? Or am I missing something?

http://www.lua.org/pil/1.3.html

commented

LUA comments do not work within the bracket quotes.

lfo@throne;160$ lua 
Lua 5.1.4  Copyright (C) 1994-2008 Lua.org, PUC-Rio
> a = [[ hello
-- there
Brandon 
]]
> print(a)
 hello
-- there
Brandon 
> 
commented

Learn something new every day. :) Thanks, Ludovicus.

commented

Are you trying to change the LUA code or the guide itself? If its the guide, then the parser controls that as its just a string and you can use any charcter combination you wish to ignore anything beyond that point.

commented

Ludovicus - What I've been starting to encourage people to do is fork the project then send a pull request. That way anyone can submit changes and I don't have to worry about making sure everyone has the correct permissions.

Let me know if that works for you!

Twists - it is with the guide file, it seemed very simple but I recall when I attempted to set it up it didn't work. Honestly it was quite a few months ago so I don't remember the details and haven't messed with it since.

commented

OK, forked yesterday and sent the pull request.

#313

commented

Awesome, pulling it in today, just fixing a couple other bugs RQ