More taint issues
silvann opened this issue ยท 6 comments
More taint issues, by evl via WoWI, posted 28/10 12:24 AM:
10/25 22:27:49.543 Global variable bottomShownFrame tainted by WoWPro_Leveling - Interface\FrameXML\QuestInfo.lua:61 QuestInfo_Display()
10/25 22:27:49.543 Interface\FrameXML\WorldMapFrame.lua:1853 WorldMapFrame_SelectQuestFrame()
10/25 22:27:49.543 Interface\FrameXML\WorldMapFrame.lua:1643 WorldMapFrame_SelectQuestById()
10/25 22:27:49.543 Interface\FrameXML\WorldMapFrame.lua:1615 WorldMapFrame_DisplayQuests()
10/25 22:27:49.543 Interface\FrameXML\WorldMapFrame.lua:1686 WorldMapFrame_UpdateMap()
10/25 22:27:49.543 Interface\FrameXML\WorldMapFrame.lua:190
10/25 22:27:49.543 SetMapToCurrentZone()
10/25 22:27:49.543 Interface\FrameXML\WorldMapFrame.lua:157
10/25 22:27:49.543 WorldMapFrame:Show()
10/25 22:27:49.543 Interface\FrameXML\UIParent.lua:1420 :SetUIPanel()
10/25 22:27:49.543 Interface\FrameXML\UIParent.lua:1262 :ShowUIPanel()
10/25 22:27:49.543 Interface\FrameXML\UIParent.lua:1198
10/25 22:27:49.543 :SetAttribute()
10/25 22:27:49.543 Interface\FrameXML\UIParent.lua:1873 ShowUIPanel()
10/25 22:27:49.543 Interface\FrameXML\UIParent.lua:1857 ToggleFrame()
10/25 22:27:49.543 TOGGLEWORLDMAP:1
10/25 22:27:49.543 Execution tainted by WoWPro_Leveling while reading bottomShownFrame - Interface\FrameXML\QuestInfo.lua:69 QuestInfo_Display()
10/25 22:27:49.543 Interface\FrameXML\WorldMapFrame.lua:1853 WorldMapFrame_SelectQuestFrame()
10/25 22:27:49.543 Interface\FrameXML\WorldMapFrame.lua:1643 WorldMapFrame_SelectQuestById()
10/25 22:27:49.543 Interface\FrameXML\WorldMapFrame.lua:1615 WorldMapFrame_DisplayQuests()
10/25 22:27:49.543 Interface\FrameXML\WorldMapFrame.lua:1686 WorldMapFrame_UpdateMap()
10/25 22:27:49.543 Interface\FrameXML\WorldMapFrame.lua:190
10/25 22:27:49.543 SetMapToCurrentZone()
10/25 22:27:49.543 Interface\FrameXML\WorldMapFrame.lua:157
10/25 22:27:49.543 WorldMapFrame:Show()
10/25 22:27:49.543 Interface\FrameXML\UIParent.lua:1420 :SetUIPanel()
10/25 22:27:49.543 Interface\FrameXML\UIParent.lua:1262 :ShowUIPanel()
10/25 22:27:49.543 Interface\FrameXML\UIParent.lua:1198
10/25 22:27:49.543 :SetAttribute()
10/25 22:27:49.543 Interface\FrameXML\UIParent.lua:1873 ShowUIPanel()
10/25 22:27:49.543 Interface\FrameXML\UIParent.lua:1857 ToggleFrame()
10/25 22:27:49.543 TOGGLEWORLDMAP:1
10/25 22:27:49.543 An action was blocked in combat because of taint from WoWPro_Leveling - WorldMapBlobFrame:Show()
10/25 22:27:49.543 Interface\FrameXML\WorldMapFrame.lua:1623 WorldMapFrame_DisplayQuests()
10/25 22:27:49.543 Interface\FrameXML\WorldMapFrame.lua:1686 WorldMapFrame_UpdateMap()
10/25 22:27:49.543 Interface\FrameXML\WorldMapFrame.lua:190
10/25 22:27:49.543 SetMapToCurrentZone()
10/25 22:27:49.543 Interface\FrameXML\WorldMapFrame.lua:157
10/25 22:27:49.543 WorldMapFrame:Show()
10/25 22:27:49.543 Interface\FrameXML\UIParent.lua:1420 :SetUIPanel()
10/25 22:27:49.543 Interface\FrameXML\UIParent.lua:1262 :ShowUIPanel()
10/25 22:27:49.543 Interface\FrameXML\UIParent.lua:1198
10/25 22:27:49.543 :SetAttribute()
10/25 22:27:49.543 Interface\FrameXML\UIParent.lua:1873 ShowUIPanel()
10/25 22:27:49.543 Interface\FrameXML\UIParent.lua:1857 ToggleFrame()
10/25 22:27:49.543 TOGGLEWORLDMAP:1
One thing I didnt test regarding taint in combat is the enabling/disabling the addon (like via the minimap icon) while in combat. If that's the case, I think the only thing we can do is disable the enable/disable option during combat, because :Show() and Hide() protected frames like ours during combat will give taint problems.
by the way, I found out that the way I was checking for combat is kind of weird. I read it in an example somewhere, basically I was listening for the regen enabled/disabled events, but it would be much easier just to call the InCombatLockdown() function >_<
Weird... I had that same taint error, but instead caused by Altoholic addon. It happened when I was resizing the blizzard worldmap.
Wonder if Blizz changed some functions to cause them to be restricted to out of combat that weren't previously?