WoW-Pro Guides

WoW-Pro Guides

3M Downloads

Taint log

Mezput opened this issue ยท 6 comments

commented

Has this happening to me today:

10/30 16:16:00.733 An action was blocked in combat because of taint from WoWPro - WoWPro.AnchorFrame:ClearAllPoints()
10/30 16:16:00.733 Interface\AddOns\WoWPro\WoWPro_Frames.lua:285
10/30 16:16:00.733 An action was blocked in combat because of taint from WoWPro - WoWPro.AnchorFrame:SetPoint()
10/30 16:16:00.733 Interface\AddOns\WoWPro\WoWPro_Frames.lua:292
10/30 16:16:00.733 An action was blocked in combat because of taint from WoWPro - WoWPro.AnchorFrame:SetWidth()
10/30 16:16:00.733 Interface\AddOns\WoWPro\WoWPro_Frames.lua:307
10/30 16:16:00.733 An action was blocked in combat because of taint from WoWPro - WoWPro.AnchorFrame:SetHeight()
10/30 16:16:00.733 Interface\AddOns\WoWPro\WoWPro_Frames.lua:308
10/30 16:16:00.752 An action was blocked in combat because of taint from WoWPro - WoWPro.MainFrame:SetPoint()
10/30 16:16:00.752 Interface\AddOns\WoWPro\WoWPro_Frames.lua:310

This happened when i entered combat on ambush (froze screen) and when the mob died (froze screen again). Happens every time i repeat this procedure.

commented

We have changed the way combat is tracked - basically, what we have may still generate taint, but everything has changed pretty drastically, so if/when we encounter it again, we can deal with it. However, I'm just marking it "resolved", not closed, since we haven't pushed those changes to live yet.

As a side note, I think I will be pushing an upgrade to the live realms this weekend, if all goes as planned. I will also be making more Cataclysm guides available for download and testing.

commented

Thanks, I'll take a look at it.

commented

Jiyambi, can this has to do with how the addon deal with being in noncombat and how rogues regen energy?

commented

Possibly. I want to change how the in/out of combat detection is handled - it's currently rather archaic. We can just use InCombatLockdown() instead.

commented

I'm currently using InCombatLockdown() on the "Cataclysm" branch (which is the one I've been actively developing - yes my version control fu needs some work >_< ). I haven't seen any taint issues, keep me aware of any you find.

commented

From the other taint issue;

More taint issues, by evl via WoWI, posted 28/10 12:24 AM:

10/25 22:27:49.543 Global variable bottomShownFrame tainted by WoWPro_Leveling - Interface\FrameXML\QuestInfo.lua:61 QuestInfo_Display()
10/25 22:27:49.543 Interface\FrameXML\WorldMapFrame.lua:1853 WorldMapFrame_SelectQuestFrame()
10/25 22:27:49.543 Interface\FrameXML\WorldMapFrame.lua:1643 WorldMapFrame_SelectQuestById()
10/25 22:27:49.543 Interface\FrameXML\WorldMapFrame.lua:1615 WorldMapFrame_DisplayQuests()
10/25 22:27:49.543 Interface\FrameXML\WorldMapFrame.lua:1686 WorldMapFrame_UpdateMap()
10/25 22:27:49.543 Interface\FrameXML\WorldMapFrame.lua:190
10/25 22:27:49.543 SetMapToCurrentZone()
10/25 22:27:49.543 Interface\FrameXML\WorldMapFrame.lua:157
10/25 22:27:49.543 WorldMapFrame:Show()
10/25 22:27:49.543 Interface\FrameXML\UIParent.lua:1420 :SetUIPanel()
10/25 22:27:49.543 Interface\FrameXML\UIParent.lua:1262 :ShowUIPanel()
10/25 22:27:49.543 Interface\FrameXML\UIParent.lua:1198
10/25 22:27:49.543 :SetAttribute()
10/25 22:27:49.543 Interface\FrameXML\UIParent.lua:1873 ShowUIPanel()
10/25 22:27:49.543 Interface\FrameXML\UIParent.lua:1857 ToggleFrame()
10/25 22:27:49.543 TOGGLEWORLDMAP:1
10/25 22:27:49.543 Execution tainted by WoWPro_Leveling while reading bottomShownFrame - Interface\FrameXML\QuestInfo.lua:69 QuestInfo_Display()
10/25 22:27:49.543 Interface\FrameXML\WorldMapFrame.lua:1853 WorldMapFrame_SelectQuestFrame()
10/25 22:27:49.543 Interface\FrameXML\WorldMapFrame.lua:1643 WorldMapFrame_SelectQuestById()
10/25 22:27:49.543 Interface\FrameXML\WorldMapFrame.lua:1615 WorldMapFrame_DisplayQuests()
10/25 22:27:49.543 Interface\FrameXML\WorldMapFrame.lua:1686 WorldMapFrame_UpdateMap()
10/25 22:27:49.543 Interface\FrameXML\WorldMapFrame.lua:190
10/25 22:27:49.543 SetMapToCurrentZone()
10/25 22:27:49.543 Interface\FrameXML\WorldMapFrame.lua:157
10/25 22:27:49.543 WorldMapFrame:Show()
10/25 22:27:49.543 Interface\FrameXML\UIParent.lua:1420 :SetUIPanel()
10/25 22:27:49.543 Interface\FrameXML\UIParent.lua:1262 :ShowUIPanel()
10/25 22:27:49.543 Interface\FrameXML\UIParent.lua:1198
10/25 22:27:49.543 :SetAttribute()
10/25 22:27:49.543 Interface\FrameXML\UIParent.lua:1873 ShowUIPanel()
10/25 22:27:49.543 Interface\FrameXML\UIParent.lua:1857 ToggleFrame()
10/25 22:27:49.543 TOGGLEWORLDMAP:1
10/25 22:27:49.543 An action was blocked in combat because of taint from WoWPro_Leveling - WorldMapBlobFrame:Show()
10/25 22:27:49.543 Interface\FrameXML\WorldMapFrame.lua:1623 WorldMapFrame_DisplayQuests()
10/25 22:27:49.543 Interface\FrameXML\WorldMapFrame.lua:1686 WorldMapFrame_UpdateMap()
10/25 22:27:49.543 Interface\FrameXML\WorldMapFrame.lua:190
10/25 22:27:49.543 SetMapToCurrentZone()
10/25 22:27:49.543 Interface\FrameXML\WorldMapFrame.lua:157
10/25 22:27:49.543 WorldMapFrame:Show()
10/25 22:27:49.543 Interface\FrameXML\UIParent.lua:1420 :SetUIPanel()
10/25 22:27:49.543 Interface\FrameXML\UIParent.lua:1262 :ShowUIPanel()
10/25 22:27:49.543 Interface\FrameXML\UIParent.lua:1198
10/25 22:27:49.543 :SetAttribute()
10/25 22:27:49.543 Interface\FrameXML\UIParent.lua:1873 ShowUIPanel()
10/25 22:27:49.543 Interface\FrameXML\UIParent.lua:1857 ToggleFrame()
10/25 22:27:49.543 TOGGLEWORLDMAP:1