WoW-Pro Guides

WoW-Pro Guides

3M Downloads

Error caused by mouseover note

silvann opened this issue ยท 4 comments

commented

So, WoWPro.RowSizeSet() is called by a function inside the addon's OnEnable, before a guide is properly loaded into the WoWPro tags tables. But, there's one place in RowSizeSet() that uses the row note's content, line 194:

if WoWProDB.profile.mousenotes and (WoWPro.note[row.index] or (WoWPro.map[row.index] and WoWProDB.profile.showcoords)) then

commented

oooo I was confused, I checked this but for some reason in my sleep-deprived brain I thought it was referencing the note FRAME, not the note table for that guide. I understand why it wasn't working now. Thanks Silvann!

commented

BTW, it was an unelegant fix, because I think there are functions there are called more than one time and/or called when not needed. But this is gonna take more time and more tests.

commented

It is and there are. I want to work on this further in terms of fixing these extra calls, streamlining things, etc - but I'm making it a back-seat to recording things since I'm pretty efficient at that and there's still a LOT to get done.

commented

Yeah, definately. That's why I went ahead and implemented the quick and dirty fix. ;)