Taint... again
silvann opened this issue ยท 5 comments
12/6 02:27:57.642 An action was blocked in combat because of taint from WoWPro - WoWPro.AnchorFrame:ClearAllPoints()
12/6 02:27:57.642 Interface\AddOns\WoWPro\WoWPro_Frames.lua:295
12/6 02:27:57.642 An action was blocked in combat because of taint from WoWPro - WoWPro.AnchorFrame:SetPoint()
12/6 02:27:57.642 Interface\AddOns\WoWPro\WoWPro_Frames.lua:314
12/6 02:27:57.642 An action was blocked in combat because of taint from WoWPro - WoWPro.AnchorFrame:SetWidth()
12/6 02:27:57.642 Interface\AddOns\WoWPro\WoWPro_Frames.lua:317
12/6 02:27:57.642 An action was blocked in combat because of taint from WoWPro - WoWPro.AnchorFrame:SetHeight()
12/6 02:27:57.642 Interface\AddOns\WoWPro\WoWPro_Frames.lua:318
12/6 02:27:57.657 An action was blocked in combat because of taint from WoWPro - WoWPro.MainFrame:SetPoint()
12/6 02:27:57.657 Interface\AddOns\WoWPro\WoWPro_Frames.lua:320
It seems the culprit is the function WoWPro.AnchorSet(), but I got confused with all the OnUpdate scripts in your code. Jiyambi, once you have the time, can you explain that part of the code? I'm afraid to change it and break something else.
Silvann - I need to rework that whole nasty mess. I put all those in when I was trying to get the drag -- get new position -- move the anchor frame -- set our guide to anchor properly -- anchor our guide to the anchor frame.
But I've been thinking about it and we should be able to ditch that nasty anchor frame altogether. I will make this my next project after I get everything uploaded for tonight's update.
Anchor frame went byebye, I have NO idea why I was making that arbitrarily more complicated. Go-go noob coding!
One OnUpdate function is still needed AFAIK because when the frame is dragged, the get position functions don't work right away. So they are found and the anchor point is set OnUpdate, then the OnUpdate function is cleared from the frame.
I will make this only happen if the person is out of combat, that should fix the taint log and will be easy to do - it will keep checking the combat status OnUpdate until they get out of there.