WoW-Pro Guides

WoW-Pro Guides

3M Downloads

Darkmoon Faire

Twists opened this issue ยท 8 comments

commented

Almost have the darkmoon faire complete. Just running it through a final check. One issues I did run across in the World Event module is that it will not find Neutral Guides. I couldn't find out why, so if somone else can look that will help. In the mean time the guilde will be in the neutral directory but with an Alliance tag.

commented

Did you add the entries to the Neutral\Guides.xml right?

On Jan 1, 2012, at 6:12 PM, Twists wrote:

Almost have the darkmoon faire complete. Just running it through a final check. One issues I did run across in the World Event module is that it will not find Neutral Guides. I couldn't find out why, so if somone else can look that will help. In the mean time the guilde will be in the neutral directory but with an Alliance tag.


Reply to this email directly or view it on GitHub:
#353

commented

Honestly it maybe something I missed/delete by accident when making the World Events module.

I know, dumb question, but did you restart WoW after editing the xml?

commented

Yes, I did. It is still in the Neutral directory, but I had to change the faction from Neutral in the guide to Alliance for it to pick up.

commented

Hmm, the code in WoWPro.WorldEvents:RegisterGuide() looks like an almost direct copy of the Leveling one.
But that code requires the nextGIDvalue to be set, and it is not a parameter to the function anymore.
I would suggest deleting the following code block:

if factionname == "Neutral" then
    -- nextGIDvalue is faction dependent.   Split it and pick the right one "AllianceGUID|HordeGID"
    local  AllianceGUID, HordeGID = string.split("|",nextGIDvalue)
    if myUFG == "Alliance" then
        nextGIDvalue = AllianceGUID
    else
        nextGIDvalue = HordeGID
    end
        WoWPro:dbp("Neutral Guide "..GIDvalue.." for "..myUFG.." chose "..nextGIDvalue)
end

On Jan 1, 2012, at 11:22 PM, Twists wrote:

Yes, I did. It is still in the Neutral directory, but I had to change the faction from Neutral in the guide to Alliance for it to pick up.


Reply to this email directly or view it on GitHub:
#353 (comment)

commented

Yep, I forgot something. Sorry about that.

commented

ok.. let me try and that and see what happens.

commented

That worked.

commented

Ok, the module and guide is out there. Still needs a bit of work, but its something. Sorry I couln't get just the guide, but some of the code didn't work. I will work on porting my code changes from it over to the achievement module as well.