Additional Enchanted Miner

Additional Enchanted Miner

23M Downloads

Quarry entities not impacted by lighting

valknight opened this issue ยท 1 comments

commented

Describe the bug

Quarry "arm" and drill is unlit. With shaders on, this causes the arm to potentially render into the threshold for bloom, or otherwise very bright.

I've taken a cursory look through the source code, but unfortunately I'm unfamiliar with how Minecraft mod rendering works and it's past midnight ๐Ÿ˜…

To Reproduce

Steps to reproduce the behavior:

  1. Create quarry
  2. Power quarry

Expected:
Quarry entity is impacted by lighting

Actual:
Quarry entity is not impacted by lighting

Reproduction screenshot:

unlit_minearm

Note the arm is brighter in this example than the blocks around it

Versions

  • Minecraft version: 1.21.1
  • Single Player or Multi Player?: Multi Player + Single Player impacted
  • Fabric version: 0.16.5
  • QuarryPlus version: 21.1.103
Other mods

I can imagine potentially one of the rendering mods I'm using being an issue - when I have some spare time, I'll double check to see if this repros without this :)

Crash report or logs

  • TODO: But, given this is a graphical issue, the screenshot is a sort of log ๐Ÿ˜„ (not really, I just need a log without multiplayer chat in it)
commented

I pass the "fixed" light to renderer, but I should get the light value for each position. I don't think getting light value for all position arm exists in every subticks is light, but I'll see.