Aqua Acrobatics [Forge]

Aqua Acrobatics [Forge]

2M Downloads

Custom Player Model compatibility problem

AileRozy opened this issue ยท 5 comments

commented

https://www.curseforge.com/minecraft/mc-mods/custom-player-model-cpm

using this mod with Aqua Acrobatics makes player that with custom hitbox got some problem

2021-02-18_17 16 45
2021-02-18_17 16 57
Player can't sneak while near any blocks, and anything that need player to sneak won't think player is sneaking while pressing it,
while sneaking, moving close to blocks makes hitbox go back to standing pose but eye height stay at sneaking height.

2021-02-18_17 17 28
2021-02-18_17 17 43
Swimming hitbox won't change to Aqua Acrobatics style but eye height are fine, not sure this can fix on CPM side of player custom or not,
when swimming head is facing strange angle.

commented

Unfortunately, by design, Aqua Acrobatics is going to be incompatible with a lot of mods that replace the player model; the expectation is that a mostly-vanilla player is in use (to the best of my knowledge). These mods are coded against the assumption that the player doesn't swim, since that never happened in 1.12.

Morph does work without problems for the most part.

commented

I am trying to add more compatibility to CPM by mixin, and I found it is not impossible
This is CPM's only usage of setEntityBoundingBox: https://github.com/Gamepiaynmo/CustomModel/blob/9dd4bc3031f4f958fdc3b3895ca4c56afa642bba/src/main/java/com/github/gamepiaynmo/custommodel/mixin/PlayerStatureHandler.java#L33
And calling CustomModel.manager.getModelForPlayer(serverPlayer) can check if a player has model enabled

commented

I want to add more to this issue.

What I observed is that the bounding box gets set to custom values by a model, but doesn't get reset back to normal when either the model is reset to default or the new model doesn't set custom bounding box size.
This problems gets fixed upon re-joining the world.
2021-03-03_14 53 49
2021-03-03_14 53 58

Also even when the bounding box is smaller than a needed space (e.g. 1,5 block when trying to go under 2, or less than 1 when going into 1 block space) the player still gets treated as if their bounding box is bigger (according to AquaAcrobatics push-out setting.)
2021-03-03_14 54 57
2021-03-03_14 55 02

commented

Are you still using aquaacro? I also use more player models.

commented

I also wanted to add that the issue in the comment above also happens with Changeling/Metamorph mods as well. the only thing that seems to "fix" the issue is if I morph into an entity that is 2 blocks high (like a skeleton, zombie, etc), and then revert back to normal.

Also, the crawling feature appears to only activate randomly when approaching 1-block tall spaces.