Carpet Shadow

Carpet Shadow

11.9k Downloads

ShadowItemToolTip compatibility in LAN servers

Arthur-Montgomery opened this issue ยท 6 comments

commented

Sorry to bother ,do you mind fixing this mod so that LAN server players can also see the tooltip? When I was playing with my friends (all of us have installed carpet shadow), me who opened the LAN server can see the tooltip, while it's invisible to all my friends. It's really inconvenient since they can easily break shadow items without realizing it is a shadow item. It would be really nice if you fix that problem.

commented

that is weird, unless the integrated server does things differently from the dedicated one it should not matter.

this needs to be investigated a bit more

commented

I've seen similar things happening in other mods, for example in syncmatica(addon of litematica, in which you can send schematicas to, or download them from the server ,in order to share them with others in the server). their solution was to make it possible to do so even in single player, and that works perfectly in LAN.(my guess is MC mods sees LAN as singleplayer, so if you want something to work on LAN, it have to be able to work in singleplayer.) I suppose this might be useful?

commented

v 1.10.0 fro 1.19.4 should fix this issue

commented

Thank you very much. Btw, what should I do if I want to make this fix work in 1.17? Which part of the code should I transfer to the 1.17 mod?

commented


this line is the one responsible for the bug.. the problem is by removing it, few unexpected behaviors will happen in singleplayer
the fix was to implement the ClientShadowId part of the last few 1.20 commits

commented

Sorry but I just don't understand... Should I delete this specific line in 1.17 version or find the ClientShadowId document in 1.20 commits and put it in 1.17? (I didn't find anything named like ClientShadowId)
I don't know much about the code stuff, so please tell me more details, if you may. Sorry for taking up your time.