Carpet Shadow

Carpet Shadow

11.9k Downloads

1.20.1 - Dropper Fragility Fix Crash

SirReal314 opened this issue ยท 13 comments

commented

Ticking droppers causes server crash. Only mods were: Fabric API, Carpet, Carpet Fixes, and Carpet Shadow.

[Server thread/ERROR]: Encountered an unexpected exception
net.minecraft.class_148: Exception ticking world
        at net.minecraft.server.MinecraftServer.method_3813(MinecraftServer.java:901) ~[server-intermediary.jar:?]
        at net.minecraft.class_3176.method_3813(class_3176.java:283) ~[server-intermediary.jar:?]
        at net.minecraft.server.MinecraftServer.method_3748(MinecraftServer.java:824) ~[server-intermediary.jar:?]
        at net.minecraft.server.MinecraftServer.handler$zbl000$carpet$modifiedRunLoop(MinecraftServer.java:9442) ~[server-intermediary.jar:?]
        at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:650) ~[server-intermediary.jar:?]
        at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:265) ~[server-intermediary.jar:?]
        at java.lang.Thread.run(Thread.java:833) ~[?:?]
Caused by: org.spongepowered.asm.mixin.injection.throwables.InjectionError: LVT in net/minecraft/class_2325::method_10012(Lnet/minecraft/class_3218;Lnet/minecraft/class_2338;)V has incompatible changes at opcode 149 in callback carpet-shadow.mixins.json:fragility.DropperBlockMixin from mod carpet-shadow->@Inject::fix_dispense(Lnet/minecraft/class_3218;Lnet/minecraft/class_2338;Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;Lnet/minecraft/class_2345;Lnet/minecraft/class_2601;ILnet/minecraft/class_1799;Lnet/minecraft/class_2350;Lnet/minecraft/class_1263;Lnet/minecraft/class_1799;)V.
 Expected: [Lnet/minecraft/class_2345;, Lnet/minecraft/class_2601;, I, Lnet/minecraft/class_1799;, Lnet/minecraft/class_2350;, Lnet/minecraft/class_1263;, Lnet/minecraft/class_1799;]
    Found: [Lnet/minecraft/class_2345;, Lnet/minecraft/class_2601;, I, Lnet/minecraft/class_1799;, Lnet/minecraft/class_1799;]
Available: [Lnet/minecraft/class_2345;, Lnet/minecraft/class_2601;, I, Lnet/minecraft/class_1799;, Lnet/minecraft/class_1799;]
        at net.minecraft.class_2325.handler$blg000$carpet-shadow$fix_dispense$missing(class_2325.java) ~[server-intermediary.jar:?]
        at net.minecraft.class_2325.method_10012(class_2325.java:68) ~[server-intermediary.jar:?]
        at net.minecraft.class_2315.method_9588(class_2315.java:113) ~[server-intermediary.jar:?]
        at net.minecraft.class_4970$class_4971.method_26192(class_4970.java:1113) ~[server-intermediary.jar:?]
        at net.minecraft.class_3218.method_14189(class_3218.java:728) ~[server-intermediary.jar:?]
        at net.minecraft.class_6757.method_39390(class_6757.java:215) ~[server-intermediary.jar:?]
        at net.minecraft.class_6757.method_39377(class_6757.java:98) ~[server-intermediary.jar:?]
        at net.minecraft.class_3218.method_18765(class_3218.java:323) ~[server-intermediary.jar:?]
        at net.minecraft.server.MinecraftServer.redirect$bcm000$carpet-fixes$catchExceptions(MinecraftServer.java:4331) ~[server-intermediary.jar:?]
        at net.minecraft.server.MinecraftServer.method_3813(MinecraftServer.java:897) ~[server-intermediary.jar:?]
        ... 6 more
commented

this is what i get for trying to use beta versions ๐Ÿ˜‚
Had to downgrade from bata8 to beta4 because MixinExtras was breaking the refmaps

please try the re-uploaded version

commented
commented

I have the same issue:

https://mclo.gs/3UkP4ig

commented

i'll try and investigate tomorrow then.

commented

Now the WrapOperation in PacketByteBufMixin causes a crash. I have an hour, so I'll take a look as well.

https://pastebin.com/r3WFFJ7Y

commented

On the latest version (v1.10.1) I am also encountering the crash with only the carpet mods and fabric api on launch. Here is my crash log https://paste.ee/p/aUVmb

I have a same problem

commented

On the latest version (v1.10.1) I am also encountering the crash with only the carpet mods and fabric api on launch.
Here is my crash log https://paste.ee/p/aUVmb

commented

Yep, no more crashes. However, tool tip lore doesn't show up. I think this was the case before your fixes but didn't notice. The console does log the new item being created and the shadow id is in the item nbt, but the lore just isn't added. I'll take a deeper look at it in an hour.

commented

can you open a new issue for that?
also is that in single player or multiplayer?

commented

anyways i'll mark this issue as completed

commented

Thanks for your help. And nevermind. Upon closer inspection, the lore issue was due to PolyMC. We need it for carpet autocrafting table with regsync in the new Fabric API. If you still want me to create a new issue, I will.

commented

i've found the problem and fixed it anyways i'm doing the 1.10.2 release now ๐Ÿ˜‚