Carpet Shadow

Carpet Shadow

11.9k Downloads

New bugs after switching on 1.20

Blyued opened this issue · 6 comments

commented

After switching to Minecraft version 1.20 on the server, I encountered many problems (with the same configurations). 1) Food, trident, bow and items that are used by long pressing the RMB, when linked, stop working normally, they instantly reset the action and try to perform it again, and so on ad infinitum. 2) After the server restart, the link for all shadow items disappears, after certain tests, I found out that if you leave the server before the restart, the link will remain for the items in your inventory, but if you are on the server during the restart or put the linked item in the chest , then after the restart it is duped and unlinked (shadowItemMod is set to persist). 3) When a player dies with a linked item in his inventory, the item is duped and unlinked. Maybe it was me who did something wrong, but I still ask you to please help me.

My discord - blyued, If you need to show exactly what the problem is.

If this helps in any way, here are the logs:
Starting net.fabricmc.loader.impl.game.minecraft.BundlerClassPathCapture
[09:43:46] [main/INFO]: Loading Minecraft 1.20.1 with Fabric Loader 0.14.22
[09:43:46] [ForkJoinPool-1-worker-3/WARN]: The mod "carpet-shadow" contains invalid entries in its mod json:

  • Invalid entry in person "comment" at line 22 column 16
    [09:43:46] [main/INFO]: Loading 52 mods:
    - carpet 1.4.112+v230608
    - carpet-fixes 1.20-1.16.1
    -- com_github_llamalad7_mixinextras 0.2.0-beta.9
    - carpet-shadow 1.10.2-MC1.20.1+
    - carpet-tis-addition 1.49.0
    -- conditional-mixin 0.3.2
    - cloth-config 11.1.106
    -- cloth-basic-math 0.6.1
    - fabric-api 0.86.1+1.20.1
    |-- fabric-api-base 0.4.30+7abfd51577
    |-- fabric-api-lookup-api-v1 1.6.35+4d8536c977
    |-- fabric-biome-api-v1 13.0.10+b3afc78b77
    |-- fabric-block-api-v1 1.0.9+e022e5d177
    |-- fabric-blockrenderlayer-v1 1.1.40+b3afc78b77
    |-- fabric-client-tags-api-v1 1.1.1+97bb207577
    |-- fabric-command-api-v1 1.2.33+f71b366f77
    |-- fabric-command-api-v2 2.2.12+b3afc78b77
    |-- fabric-commands-v0 0.2.50+df3654b377
    |-- fabric-containers-v0 0.1.62+df3654b377
    |-- fabric-content-registries-v0 4.0.9+b3afc78b77
    |-- fabric-convention-tags-v1 1.5.4+a1a980da77
    |-- fabric-crash-report-info-v1 0.2.18+aeb40ebe77
    |-- fabric-data-generation-api-v1 12.2.1+1e61dba177
    |-- fabric-dimensions-v1 2.1.52+b3afc78b77
    |-- fabric-entity-events-v1 1.5.22+b3afc78b77
    |-- fabric-events-interaction-v0 0.6.1+e91849a877
    |-- fabric-events-lifecycle-v0 0.2.62+df3654b377
    |-- fabric-game-rule-api-v1 1.0.38+b04edc7a77
    |-- fabric-item-api-v1 2.1.27+b3afc78b77
    |-- fabric-item-group-api-v1 4.0.10+23d9108177
    |-- fabric-key-binding-api-v1 1.0.36+fb8d95da77
    |-- fabric-keybindings-v0 0.2.34+df3654b377
    |-- fabric-lifecycle-events-v1 2.2.21+b3afc78b77
    |-- fabric-loot-api-v2 1.1.39+b3afc78b77
    |-- fabric-loot-tables-v1 1.1.43+9e7660c677
    |-- fabric-message-api-v1 5.1.7+3265161977
    |-- fabric-mining-level-api-v1 2.1.49+b3afc78b77
    |-- fabric-model-loading-api-v1 1.0.2+709a987177
    |-- fabric-models-v0 0.4.1+9386d8a777
    |-- fabric-networking-api-v1 1.3.9+b3afc78b77
    |-- fabric-networking-v0 0.3.49+df3654b377
    |-- fabric-object-builder-api-v1 11.1.1+6beca84877
    |-- fabric-particles-v1 1.1.1+201a23a077
    |-- fabric-recipe-api-v1 1.0.19+b3afc78b77
    |-- fabric-registry-sync-v0 2.3.1+4df89eb277
    |-- fabric-renderer-api-v1 3.1.1+9386d8a777
    |-- fabric-renderer-indigo 1.4.1+9172968c77
    |-- fabric-renderer-registries-v1 3.2.45+df3654b377
    |-- fabric-rendering-data-attachment-v1 0.3.34+b3afc78b77
    |-- fabric-rendering-fluids-v1 3.0.27+b3afc78b77
    |-- fabric-rendering-v0 1.1.48+df3654b377
    |-- fabric-rendering-v1 3.0.7+b3afc78b77
    |-- fabric-resource-conditions-api-v1 2.3.5+ea08f9d877
    |-- fabric-resource-loader-v0 0.11.9+132c48c177
    |-- fabric-screen-api-v1 2.0.7+b3afc78b77
    |-- fabric-screen-handler-api-v1 1.3.28+b3afc78b77
    |-- fabric-sound-api-v1 1.0.12+b3afc78b77
    |-- fabric-transfer-api-v1 3.3.0+cdf060b277
    -- fabric-transitive-access-wideners-v1 4.3.0+6c31357e77
    - fabricloader 0.14.22
    - java 17
    - krypton 0.2.3
    -- com_velocitypowered_velocity-native 3.2.0-SNAPSHOT
    - minecraft 1.20.1
    - restart-server 1.1.1+mc1.19.x-1.20.x
    [09:43:46] [main/INFO]: SpongePowered MIXIN Subsystem Version=0.8.5 Source=file:/C:/Users/user/Desktop/fb/libraries/net/fabricmc/sponge-mixin/0.12.5+mixin.0.8.5/sponge-mixin-0.12.5+mixin.0.8.5.jar Service=Knot/Fabric Env=SERVER
    [09:43:46] [main/INFO]: Compatibility level set to JAVA_17
    [09:43:50] [main/WARN]: Method overwrite conflict for method_5800 in carpet-fixes.mixins.json:itemFixes.ItemEntity_lightningKillsDropsMixin from mod carpet-fixes, previously written by carpet.mixins.ItemEntityMixin. Skipping method.
    [09:43:50] [main/WARN]: @Inject(@at("INVOKE")) Shift.BY=2 on carpet-shadow.mixins.json:fragility.ItemEntityMixin from mod carpet-shadow::handler$bhe000$carpet-shadow$setEntityForStack exceeds the maximum allowed value: 0. Increase the value of maxShiftBy to suppress this warning.
    [09:43:53] [main/WARN]: Method overwrite conflict for getConnection in fabric-networking-api-v1.mixins.json:accessor.ServerPlayNetworkHandlerAccessor from mod fabric-networking-api-v1, previously written by carpet.mixins.ServerGamePacketListenerImpl_coreMixin. Skipping method.
    [09:43:53] [main/WARN]: Method overwrite conflict for getConnection in krypton.mixins.json:shared.network.util.ServerPlayNetworkHandlerAccessor from mod krypton, previously written by carpet.mixins.ServerGamePacketListenerImpl_coreMixin. Skipping method.
    [09:43:55] [main/INFO]: Carpet Shadow Loading!
    [09:43:55] [TISCM Mapping/INFO]: Yarn mapping file yarn-1.20.1+build.10-v2.tiny loaded
    [09:43:55] [main/INFO]: Compression will use Java, encryption will use Java
    [09:43:55] [main/INFO]: Carpet Shadow Loaded!
    [09:43:55] [main/INFO]: Krypton is now accelerating your Minecraft server's networking stack ?
    [09:43:55] [main/INFO]: [Restart Server] Loading!
    [09:43:55] [main/INFO]: Environment: authHost='https://authserver.mojang.com', accountsHost='https://api.mojang.com', sessionHost='https://sessionserver.mojang.com', servicesHost='https://api.minecraftservices.com', name='PROD'
    [09:43:56] [main/INFO]: [fabric-registry-sync] Loaded registry data [file 1/4]
    [09:43:56] [main/WARN]: @Inject(@at("INVOKE")) Shift.BY=2 on carpet-shadow.mixins.json:crafting.RecipeManagerMixin from mod carpet-shadow::handler$bhb000$carpet-shadow$addShadowRecipe exceeds the maximum allowed value: 0. Increase the value of maxShiftBy to suppress this warning.
    [09:43:56] [main/ERROR]: Failed to add settings command for carpet-fixes. It is masking previous command.
    [09:43:57] [main/INFO]: Loaded 7 recipes
    [09:43:57] [main/INFO]: Loaded 1271 advancements
    [09:43:57] [main/INFO]: Applied 0 biome modifications to 0 of 64 new biomes in 1.959 ms
    [09:43:57] [Server thread/INFO]: Starting minecraft server version 1.20.1
    [09:43:57] [Server thread/INFO]: Loading properties
    [09:43:57] [Server thread/INFO]: Default game type: SURVIVAL
    [09:43:57] [Server thread/INFO]: Generating keypair
    [09:43:57] [Server thread/INFO]: Starting Minecraft server on *:25565
    [09:43:57] [Server thread/INFO]: Using default channel type
    [09:43:57] [Server thread/INFO]: Preparing level "world"
    [09:43:57] [Server thread/INFO]: [CM] Loaded 10 settings from carpet.conf
    [09:43:57] [Server thread/INFO]: [CM] Loaded 4 settings from carpet-fixes.conf
    [09:43:58] [Server thread/INFO]: Preparing start region for dimension minecraft:overworld
    [09:44:00] [Worker-Main-9/INFO]: Preparing spawn area: 0%
    [09:44:00] [Worker-Main-9/INFO]: Preparing spawn area: 0%
    [09:44:00] [Worker-Main-6/INFO]: Preparing spawn area: 0%
    [09:44:00] [Worker-Main-10/INFO]: Preparing spawn area: 0%
    [09:44:00] [Worker-Main-5/INFO]: Preparing spawn area: 4%
    [09:44:01] [Server thread/INFO]: Time elapsed: 2441 ms
    [09:44:01] [Server thread/INFO]: keepalive app loaded
    [09:44:01] [Server thread/INFO]: App keepalive loaded in 20 ms
    [09:44:01] [Server thread/INFO]: Done (3.518s)! For help, type "help"
commented

I'm having the same problem. I use OpenJDK on Linux and play Minecraft locally with the integrated server. With only the Carpet mod and Carpet-Shadow I experience the same bug.
If anyone has a hint about what causes this, I will be glad to contribute :)

commented

i found out why the items unlink on server restarts ( it's from a compatibility change i made for single player support ) but i havent found the cause of the other problems yet... i was planing on shipping all the fixes in the 1.20.2 upgrade but that too is taking a lot of time thanks to mojang changes and irl stuff...

i'll try and fix as soon as i can but can't give an ETA

commented

No worries! Thank you very much for this mod!! I perhaps wouldn't have upgraded my Minecraft world without it and it certainly provides me with much enjoyment and convenience.

As for 1.20.2, I just so happened to yesterday update the mod myself to 1.20.2. I never ended up properly finalising it because I also wanted carpet-fixes and gave up half-way through updating that. The repo is here. I think what I did is mostly ok, since when I loaded my survival world my rockets and such were shadowed. I never created a pull request because of the food bug and I think I broke the crafting recipe, but I've never used it before today so perhaps I was using it wrong.

I completely get what you mean with Mojang changing stuff loads XD
By my account, they've changed quite a few function signatures, changed how explosions are handled and changed the damage type system which, even though is perhaps for the best, is super annoying lol

I'd be happy to create a pull request if that'd save you time?

commented

please try the new Hotfix, should fix most of the issues

commented

I just checked, everything works great! Thank you very much for such a great job)))))) The best mod from the best coder :D All problems are gone!!!!!!!!!!!!!!!!!!!!!!

commented

you're welcome, hope you'll have fun with the mod😁