Breaking proxy by hand/tool other than wrench while a reader/writer is attached causes exception in server tick
Icoza opened this issue · 7 comments
I can only reproduce this issue in 1.16, but breaking a proxy by means other than Integrated Wrench causes exception in server tick loop. Crash Log. I was able to cause this crash breaking by hand and with a pickaxe.
Oh, yea, try install the IntegratedTunnels mod in your Minecraft instance, that should solve it for now, I'll solve this bug soon
You're right, with Tunnels installed I can't reproduce the crash anymore. I can't think of many cases where Dynamics would be installed without Tunnels.
Sounds good to me, probably not a very common case where one is installed without the other. Only reason I found it is because I'm testing a lot of weird edge cases right now.
Similar issue happens in 1.12 without Integrated Tunnels just so you know. It doesn't appear to cause a crash, but it does leave an invisible proxy until you break the readers/writers that were attached. I doubt many users would have Dynamics without Tunnels though. 🤷♂️
This is not hard to fix, the cause of this issue is because I recently made the WorldBlockImporter don't break the proxy block, so that is you variable have a problem, the proxy block won't be broke, so I have to check if the player that's breaking the block is the FakePlayer from IntegratedTunnels, if it is, don't allow the fake player to break it, but if you don't have IntegratedTunnels installed, it can't find the FakePlayer class, so it just crash