Marium's Soulslike Weaponry

Marium's Soulslike Weaponry

4M Downloads

Incompatibility with other mods

pufmat opened this issue ยท 2 comments

commented

Hi ๐Ÿ‘‹

Players have found that some attributes from my Pufferfish's Attributes mod don't work with Soulslike Weaponry. I investigated it and found that the issue is caused by this mixin:

@Inject(method = "modifyAppliedDamage", at = @At("TAIL"), cancellable = true)
protected void modifyAppliedDamage(DamageSource source, float amount, CallbackInfoReturnable<Float> info) {
LivingEntity entity = ((LivingEntity)(Object)this);
float newAmount = info.getReturnValue();
info.setReturnValue(ModifyDamageUtil.modifyDamageTaken(entity, newAmount, source));
}

Here and in the other places your mod uses @Inject to modify return value. This way makes it incompatible with other mods that try to modify the same value. Consider using @ModifyReturnValue instead of @Inject as it allows multiple mods to modify the same value.

commented

Hi, thanks for reaching out about this! Didn't realize this would cause conflicts, will fix this for the next update.

commented

Fixed in this commit, will be up next update.