Marium's Soulslike Weaponry

Hi 👋

Players have found that some attributes from my Pufferfish's Attributes mod don't work with Soulslike Weaponry. I investigated it and found that the issue is caused by this mixin:

Soulslike-Weaponry/src/main/java/net/soulsweaponry/mixin/LivingEntityMixin.java

Lines 32 to 37 in 51aa683

    
           @Inject(method = "modifyAppliedDamage", at = @At("TAIL"), cancellable = true) 
        
           protected void modifyAppliedDamage(DamageSource source, float amount, CallbackInfoReturnable<Float> info) { 
        
               LivingEntity entity = ((LivingEntity)(Object)this); 
        
               float newAmount = info.getReturnValue(); 
        
               info.setReturnValue(ModifyDamageUtil.modifyDamageTaken(entity, newAmount, source)); 
        
           }

Here and in the other places your mod uses @Inject to modify return value. This way makes it incompatible with other mods that try to modify the same value. Consider using @ModifyReturnValue instead of @Inject as it allows multiple mods to modify the same value.

Hi, thanks for reaching out about this! Didn't realize this would cause conflicts, will fix this for the next update.

	@Inject(method = "modifyAppliedDamage", at = @At("TAIL"), cancellable = true)
	protected void modifyAppliedDamage(DamageSource source, float amount, CallbackInfoReturnable<Float> info) {
	LivingEntity entity = ((LivingEntity)(Object)this);
	float newAmount = info.getReturnValue();
	info.setReturnValue(ModifyDamageUtil.modifyDamageTaken(entity, newAmount, source));
	}

Share to