ThaumTweaks

ThaumTweaks

192k Downloads

[Feature Request] Any Thaumcraft file name (Incompatibility with Bansoukou)

Krutoy242 opened this issue ยท 8 comments

commented

I making modpack E2E-E.
To fix issue with Web and researches, i need to use Bansoukou mod, that patches Thaumcraft .jar file.

The problem, is after patching, it changes its name to Thaumcraft-1.12.2-6.1.BETA26-patched.jar. This makes ThaumTweaks crash on startup with this crashlog:
debug.log

So, two requests:

  1. Please add error handling for case when Thaumcraft file was renamed.

Right now i had no clue why my game crashes, and only accidentally understand that it was ThaumTweaks.
It would be nice if game crashed with verbose error, like Thaumcraft-1.12.2-6.1.BETA26.jar not found for ThaumTweaks or such.

  1. Please add feature to handle renamed files.

It could be glob file search, like Thaumcraft-*.
Or please just add second possible TC file name as Thaumcraft-1.12.2-6.1.BETA26-patched.jar especially for Bansoukou.

commented

Instead of doing this, update your mod to depend MixinBooter. the archaic way of manually appending a specific jar on the classpath is very incompatible with the current 1.12.2 ecosystem. Not to mention packing mixins brings forth more problems.

commented

Ive never heard about this technology before. Using hardcoded file name is obviously a problem so I will try to migrate.

commented

No problem, its hard getting word out there about 1.12.2 since its pretty much a banned version on Forge's discord, forums and a lot of other places. https://github.com/CleanroomMC will keep you updated if you're still on 1.12.2.

commented

Uploaded on CurseForge

commented

Good stuff!

commented

Does it work? I did some testing but its impossible to try everything

commented

I'm gonna test it in a week or so.

commented

Well, its actually working! Forget to mention that.
Thank you for the fix.