Leaves and grass added by mods have no SSS effect
Xposeded opened this issue · 5 comments
Leaves and grass added by mods have no SSS effect, while those in the vanilla Minecraft have.
I am not sure if it's because I didn't get the right setting of shader or it's a compatitibility issue in Oculus.
Using Minecraft-1.18.2, forge-40.2.1, Oculus-1.6.4, Rubidium-0.5.6 and other mods that should have nothing to do with shaders.
Some screenshots in comparison with other shaders that work as expected:
This is natural, and not a bug. I had to make a list of blocks to make SSS work on with unmodded blocks. you will just have to add the modded blocks ID to theblock.properties text file, and add them to whichever of the groups of ID's that have similar blocks. Those other shaders simply added the block ID's to their lists, because that is a common mod or something. you can find their block.properties and copy paste the listed ID's into bliss's lists, to make it easier.
it is impossible to automatically detect what blocks should get SSS or not without any information to help out, like a resourcepack.
This is natural, and not a bug. I had to make a list of blocks to make SSS work on with unmodded blocks. you will just have to add the modded blocks ID to the
block.propertiestext file, and add them to whichever of the groups of ID's that have similar blocks. Those other shaders simply added the block ID's to their lists, because that is a common mod or something. you can find their block.properties and copy paste the listed ID's into bliss's lists, to make it easier.it is impossible to automatically detect what blocks should get SSS or not without any information to help out, like a resourcepack.
Thanks for answering, this really helped a lot for me! After adding blocks IDs, things do look way much better in areas with dense flora.
By the way, the grass looks a little bit of too dark which makes it not really match the environment visually, is there any way to make them brighter? Here are the screenshots for comparison:
that grass simply gets the same shading as everything else. see how the sides of blocks are darker than the up facing parts? the grass is 100% sides. so it gets the darker shade as well. SSS from the sky should help brighten them up.
for them to be brighter i would have make a special case and shade them slightly differently than everything else.
that grass simply gets the same shading as everything else. see how the sides of blocks are darker than the up facing parts? the grass is 100% sides. so it gets the darker shade as well. SSS from the sky should help brighten them up.
for them to be brighter i would have make a special case and shade them slightly differently than everything else.
Yes, I do notice that the vanilla Minecraft rendering would darken the side faces of a block to make it easier to distinguish different faces. I can't tell whether or not the grass in vanilla Minecraft rendering is influenced by this method, but its color or brightness do match the land it attached to.
These screenshots would be helpful explaining what I talked about (Shadow map is disabled):
Hope these could help figuring out what goes wrong : )
By the way, I tested the latest commit minutes ago, the short grass now looks better, but tall grass still looks too dark in the bottom part. I disabled the SSAO to make things clear:
