ForgeUI broken PTR

Question

ForgeUI broken PTR

Zeffuro opened this issue 8 years ago · 19 comments

Zeffuro commented 8 years ago

They made a lot of changes again, Most parts of ForgeUI aren't working atm, especially my health and resource bars.

Zod- · Answer 1 · 2016-09-28T12:40:36.000Z

The patch just hit the live server so stuff is broken on there too.

Zod- · Answer 2 · 2016-09-28T12:48:29.000Z

You can see their changes here: Zod-/Wildstar-Carbine-Addons@df984be

Zeffuro · Answer 3 · 2016-09-28T13:07:32.000Z

As a proof of concept I just replaced VarChange_FrameCount with NextFrame in all folders and that seems to work. Haven't been able to test performance yet cause I was testing through RDP.

Is there going to be a different event we could check?

adamjedlicka · Answer 4 · 2016-09-28T14:10:58.000Z

OK I released a new version (v0.5.9). It should be on curse soon. From my short testing it looks like everything works.

veex-ua · Answer 5 · 2016-09-28T14:30:47.000Z

Gotta love Carbine. Zero communication and stealth changes. I wasn't even aware that PTR is up.
Also really good job on a fix. This option to define amount of frames skipped actually much better than hard coded event.

Zeffuro · Answer 6 · 2016-09-28T14:33:16.000Z

Yeah I don't know what they're thinking. First they go on with their DevConnect and I was like :O We're getting some love/attention. Then get backstabbed couple of days later...

adamjedlicka · Answer 7 · 2016-09-28T14:36:41.000Z

I don't think it was intentional. I read something few months back about carbine being more careful with API deprecatetion. Or just a mistake.

On the other hand I see it as positive change. Old and no longer maintained addons stop working so ppl will have to move to ForgeUI 😈

Zeffuro · Answer 8 · 2016-09-28T14:38:40.000Z

Well the majority of the addons work if you apply the same dirty fix 💃
But yeah, I like ForgeUI and gonna keep using it.

adamjedlicka · Answer 9 · 2016-09-28T10:17:32.000Z

Ok I'll look into it. Do you knwo if there are any patchnotes for UI APIs or do I have to download PTR and test it?

adamjedlicka · Answer 10 · 2016-09-28T10:56:37.000Z

It looks like that most of the problems are caused by "VarChange_FrameCount" event. It looks like it's no longer part of the API. It can be temporarily replaced by "NextFrame" but that will make ForgeUIs performance worse.

adamjedlicka · Answer 11 · 2016-09-28T17:54:56.000Z

@barkstripe check if you have v0.5.9 . You can also try reinstalling ForgeUI. It should work.

veex-ua · Answer 12 · 2016-09-28T16:24:37.000Z

I'm confused as to why the ms/frame stat improved so drastically, especially for nameplates addon (from ~300 down to ~50 in quite busy Thayd). At first I thought the "core" module now responsible for OnFrame event calls and it has all the "load" of the addons but all what it does is sends the event across the addons. No idea what is going on here...

adamjedlicka · Answer 13 · 2016-09-28T16:43:20.000Z

I guess it's because VarChanged_FrameCount skipped every other frame. LazyUpdate by default skips two frames. Or Carbine improved something in the runtime which resulted in lost FrameCount event.

Zeffuro · Answer 14 · 2016-09-28T16:54:59.000Z

So in the end we're getting a performancew upgrade? :P

veex-ua · Answer 15 · 2016-09-28T17:01:33.000Z

I don't think they improved NextFrame event because my other addons that use this event reporting pretty much the same ms/frame values as before. I'm pretty sure that VarChange_FrameCount event made less calls per second than what LazyUpdate currently does. It visually noticable that bars are smoother so I expected actual decrease in performance. Magic?

barkstripe · Answer 16 · 2016-09-28T17:11:20.000Z

I updated ForgeUI through the Curse client, however unit frames still seems to be having an issue for me. My own unit frame just says 'nis' in small text centered on the bottom of the unit frame. If I select an enemy, no unit frame comes up. Ideas?

Zeffuro · Answer 17 · 2016-09-28T17:15:54.000Z

Did you close Curse, then reopen and open it again. I had to do that to see correct update.

barkstripe · Answer 18 · 2016-09-29T04:14:27.000Z

I did re install earlier which didn't help it, however with this new update
that was put out since my post it is now working again, but thank you for
the help guys!

On Wed, Sep 28, 2016 at 12:54 PM, Adam Jedlička [email protected]
wrote:

@barkstripe https://github.com/barkstripe check if you have v0.5.9 .
You can also try reinstalling ForgeUI. It should work.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#310 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVdiQPz-SFMkn_Jy3yVBaEHSFdqonN_Pks5quqnxgaJpZM4KIc0a
.

veex-ua · Answer 19 · 2016-09-29T22:42:58.000Z

Some useful info from CRB_Moenzuel regarding recent API changes:

The GameVar system was removed as it was only utilized for the frame count Lua event but still had a measurable effect on performance. There is still the event FrameCount which worked before and should behave like the old event. Unfortunately the fully named event VarChange_FrameCount will no longer work and this was poorly communicated. You can adjust the rate that the event is called with the console variable ui.OnFrameNotificationPeriod which has a valid range of 1 to 8 and a default of 4.

I believe deprecated VarChange_FrameCount event used same CVar so now we know how many frames were skipped.

Share to