ToxiUI - ElvUI edit

ToxiUI - ElvUI edit

349k Downloads

Siege of Boralus M+ Season 1 Portal ID still appears to be incorrect

mdpaquin opened this issue · 5 comments

commented

Description

The WunderBar HearthStone module still appears to have the incorrect ID for Siege of Boralus defined. As a result, the icon is not shown in the M+ Port dropdown even though the portal has been unlocked.

The codebase was recently updated with the correct IDs for Season 1 and, as part of that commit, Siege of Boralus was updated to ID 464256. My port ID in my spellbook is 445418. I suspect there might be different port IDs depending on if you unlocked the port back in BFA or as part of TWW Season 1. Is it possible to define multiple IDs for the same port? If so it should be as simple as adding the line...I can create a PR if you need me to.

Lua error

paste error here

ToxiUI Status Report

image

Screenshots

image

To reproduce

If this issue is describing a bug, include some steps to reproduce the behavior

  1. Have the Siege of Boralus Portal unlocked
  2. Open the M+ Portal menu of the Hearthstone Wunderbar module
commented

It's a possibility that horde & alliance have separate portal IDs, same as mage's for Shattrath etc.

I'll add this ID too, thank you.

commented

Is it possible to define multiple IDs for the same port?

Yes, as when generating the list to render, we iterate through all the IDs and check if the character has that spell id known.

commented

The horde and alliance theory is very plausible actually since there are 2 entrances to the dungeon and the alliance one ports you in the middle of Boralus...I doubt the Horde one does the same 🤣

commented

Should be fixed in v6.8.8-beta.2.

Re-open the issue if that's not the case.

commented