ToxiUI - ElvUI edit

ToxiUI - ElvUI edit

349k Downloads

[BUG] Armory: Death Knight weapon enchants

Toxicom opened this issue · 6 comments

commented

Description

Death Knight enchants are being abbreviated incorrectly with ✅ Short Enchant

To Reproduce

  1. Log into a Death Knight character
  2. Runeforge your weapons
  3. Enable ✅ Short Enchant in /tx settings -> Armory -> Item Slot
  4. See Paper Doll frame

Expected behavior

  • Death Knight Runeforge enchants show a logical string when abbreviated
  • Other enchants are also abbreviated correctly

Screenshots

Abbreviated

image

Full

image

Additional Information

  • Latest commit: b8d1bf1cd4150081ffc9b735bb58761c00628d14
  • We could look into how WrathArmory handles it:
    image
commented
commented

image

commented

I have an idea.

commented

I pulled up a DK I have to test right now. Will let you know in a second.

commented

Think this was solved with #7 , need to test:)

commented

image
image

Looks like it's working!