ToxiUI - ElvUI edit

ToxiUI - ElvUI edit

349k Downloads

Inspect scaling bug

Toxicom opened this issue ยท 3 comments

commented

Description

15x Blizzard_InspectUI/InspectPVPFrame.lua:71: Usage: UnitFactionGroup("unit" [,checkDisplayRace])
[string "=[C]"]: in function `UnitFactionGroup'
[string "@Blizzard_InspectUI/InspectPVPFrame.lua"]:71: in function `InspectPVPFrame_Update'
[string "@Blizzard_InspectUI/InspectPVPFrame.lua"]:60: in function <Blizzard_InspectUI/InspectPVPFrame.lua:58>

Locals:
(*temporary) = nil

Basically the issue here is that we force load Blizzard_InspectUI addon so that we can scale the inspect frame.
A very similar issue described here: nickbock/ElvUI_Enhanced_Again#94 (comment)

Notes

To reproduce

  1. Scale inspect frame in /tx settings
  2. Reload
  3. Hovering a player should pop the error

Acceptance criteria

  • Inspect Frame scaling works without force loading Blizzard_InspectUI
commented

WindTools does something that we should do with their skinning for the inspect frame:

But I don't fully understand how it works yet

commented

Perhaps this could be used somehow? https://github.com/Toxicom/toxiui/blob/development/Core/Functions/Event.lua#L273
Tried it like this but doesn't work (frame doesn't get scaled)

  F.Event.ContinueOnAddOnLoaded("Blizzard_InspectUI", function()
    M:SetElementScale(syncedFrameName, "InspectFrame")
  end)
commented

Fixed with #71