UnitFrame Gradient bug

Question

UnitFrame Gradient bug

onlylove943 opened this issue a year ago · 4 comments

onlylove943 commented a year ago

Description

Happen alot in solo shuffle arena after the first round The color on arena unitframe not changing when health drop.

Screenshots

Sorry didn't take any screenshot, but here's the log from bugsack

9858x ElvUI_ToxiUI/Core/Functions/Core.lua:114: attempt to perform arithmetic on local 'a' (a nil value)
[string "@ElvUI_ToxiUI/Core/Functions/Core.lua"]:114: in function `AlmostEqual'
[string "@ElvUI_ToxiUI/Core/Functions/Color.lua"]:10: in function `EqualToRGB'
[string "@ElvUI_ToxiUI/Modules/Themes/Gradients/Update.lua"]:13: in function `SetGradientColors'
[string "@ElvUI_ToxiUI/Modules/Themes/Gradients/Health.lua"]:58: in function <...Ons/ElvUI_ToxiUI/Modules/Themes/Gradients/Health.lua:42>
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
[string "@ElvUI_Libraries/Core/oUF/elements/health.lua"]:139: in function <ElvUI_Libraries/Core/oUF/elements/health.lua:86>
[string "@ElvUI_Libraries/Core/oUF/elements/health.lua"]:151: in function <ElvUI_Libraries/Core/oUF/elements/health.lua:143>
[string "@ElvUI_Libraries/Core/oUF/elements/health.lua"]:205: in function `func'
[string "@ElvUI_Libraries/Core/oUF/ouf.lua"]:1057: in function `run'
[string "@ElvUI_Libraries/Core/oUF/ouf.lua"]:1094: in function `execute'
[string "@ElvUI_Libraries/Core/oUF/ouf.lua"]:1107: in function `update'
[string "@ElvUI_Libraries/Core/oUF/ouf.lua"]:1138: in function <ElvUI_Libraries/Core/oUF/ouf.lua:1136>

Locals:
a = nil
b = 0.639216
(*temporary) = <function> defined =[C]:-1
(*temporary) = nil
(*temporary) = "attempt to perform arithmetic on local 'a' (a nil value)"
abs = <function> defined =[C]:-1

Acceptance criteria

Error is not happening anymore

Toxicom · Answer 1 · 2024-02-29T22:22:16.000Z

Alright found a way to reproduce this.
1. Do a `/reload` and make sure you're not targetting anything. UnitFrames have to be faded out.

2. Go into gradient theme settings and enable saturation boost.

3. Target something

4. You should see error
Same happens if you do the exact same steps and in step 2 disable saturation boost.

I've added some additional checks couple months ago and this is no longer reproducable. Closing the issue for now. If more bugs come up, please re-open this issue or create a new one.

Toxicom · Answer 2 · 2023-10-26T13:19:55.000Z

Happened to me just now.

2x ElvUI_ToxiUI/Core/Functions/Core.lua:114: attempt to perform arithmetic on local 'a' (a nil value)
[string "@ElvUI_ToxiUI/Core/Functions/Core.lua"]:114: in function `AlmostEqual'
[string "@ElvUI_ToxiUI/Core/Functions/Color.lua"]:10: in function `EqualToRGB'
[string "@ElvUI_ToxiUI/Modules/Themes/Gradients/Update.lua"]:13: in function `SetGradientColors'
[string "@ElvUI_ToxiUI/Modules/Themes/Gradients/Health.lua"]:58: in function <...Ons/ElvUI_ToxiUI/Modules/Themes/Gradients/Health.lua:42>
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
[string "@ElvUI_Libraries/Core/oUF/elements/health.lua"]:139: in function <ElvUI_Libraries/Core/oUF/elements/health.lua:86>
[string "@ElvUI_Libraries/Core/oUF/elements/health.lua"]:151: in function <ElvUI_Libraries/Core/oUF/elements/health.lua:143>
[string "@ElvUI_Libraries/Core/oUF/elements/health.lua"]:205: in function `func'
[string "@ElvUI_Libraries/Core/oUF/ouf.lua"]:238: in function <ElvUI_Libraries/Core/oUF/ouf.lua:221>
[string "=(tail call)"]: ?
[string "@ElvUI_Libraries/Core/oUF/ouf.lua"]:256: in function <ElvUI_Libraries/Core/oUF/ouf.lua:255>
[string "=[C]"]: in function `Show'
[string "@FrameXML/SecureStateDriver.lua"]:83: in function <FrameXML/SecureStateDriver.lua:73>
[string "@FrameXML/SecureStateDriver.lua"]:137: in function <FrameXML/SecureStateDriver.lua:119>

Locals:
a = nil
b = 0.250000
(*temporary) = <function> defined =[C]:-1
(*temporary) = nil
(*temporary) = "attempt to perform arithmetic on local 'a' (a nil value)"
abs = <function> defined =[C]:-1

missing name wtf is coming from our name tags:

local name = UnitName(unit)
      if not name then return "missing name wtf" end

So it's not entirely an issue with gradient mode, but more on elvui not finding the unit? I'm hella confused :D

How it happened:

I was in gradient mode + saturation boost
Disabled saturation boost
Targeted myself
is broken

not sure if can be reproduced reliably

Toxicom · Answer 3 · 2023-10-26T13:24:36.000Z

Alright found a way to reproduce this.

Do a /reload and make sure you're not targetting anything. UnitFrames have to be faded out.
Go into gradient theme settings and enable saturation boost.
Target something
You should see error

Same happens if you do the exact same steps and in step 2 disable saturation boost.

Toxicom · Answer 4 · 2023-10-26T16:56:50.000Z

Some more errors:

4x ElvUI_ToxiUI/Core/Functions/Color.lua:14: bad argument #2 to 'SetGradient' (Usage: self:SetGradient(orientation, minColor, maxColor))
[string "=[C]"]: in function `SetGradient'
[string "@ElvUI_ToxiUI/Core/Functions/Color.lua"]:14: in function `SetGradient'
[string "@ElvUI_ToxiUI/Modules/Themes/Gradients/Update.lua"]:82: in function `SetGradientColors'
[string "@ElvUI_ToxiUI/Modules/Themes/Gradients/Health.lua"]:58: in function <...Ons/ElvUI_ToxiUI/Modules/Themes/Gradients/Health.lua:42>
[string "=(tail call)"]: ?
[string "@ElvUI_ToxiUI/Modules/Themes/Gradients/Core.lua"]:8: in function <...ddOns/ElvUI_ToxiUI/Modules/Themes/Gradients/Core.lua:6>
[string "=(tail call)"]: ?
[string "=[C]"]: ?
[string "@ElvUI_ToxiUI/Core/Functions/Event.lua"]:170: in function <ElvUI_ToxiUI/Core/Functions/Event.lua:169>
[string "=[C]"]: ?
[string "@ElvUI_ToxiUI/Core/Functions/Event.lua"]:173: in function `TriggerEvent'
[string "@ElvUI_ToxiUI/Modules/Options/Themes/GradientMode.lua"]:114: in function <...ElvUI_ToxiUI/Modules/Options/Themes/GradientMode.lua:113>
[string "@ElvUI_ToxiUI/Modules/Options/Core.lua"]:180: in function <ElvUI_ToxiUI/Modules/Options/Core.lua:175>
[string "=[C]"]: ?
[string "@ElvUI_Libraries/Core/Ace3/AceConfig-3.0-3/AceConfigDialog-3.0-86/AceConfigDialog-3.0.lua"]:45: in function <...nfig-3.0/AceConfigDialog-3.0/AceConfigDialog-3.0.lua:43>
[string "@ElvUI_Libraries/Core/Ace3/AceConfig-3.0-3/AceConfigDialog-3.0-86/AceConfigDialog-3.0.lua"]:869: in function <...nfig-3.0/AceConfigDialog-3.0/AceConfigDialog-3.0.lua:691>
[string "=[C]"]: ?
[string "@Questie/Libs/AceGUI-3.0-41/AceGUI-3.0.lua"]:66: in function <Questie/Libs/AceGUI-3.0/AceGUI-3.0.lua:64>
[string "@Questie/Libs/AceGUI-3.0-41/AceGUI-3.0.lua"]:300: in function `Fire'
[string "@ElvUI_Libraries/Core/Ace3/AceGUI-3.0-41/widgets/AceGUIWidget-ColorPicker.lua"]:28: in function <...Ace3/AceGUI-3.0/widgets/AceGUIWidget-ColorPicker.lua:17>
[string "@ElvUI_Libraries/Core/Ace3/AceGUI-3.0-41/widgets/AceGUIWidget-ColorPicker.lua"]:60: in function <...Ace3/AceGUI-3.0/widgets/AceGUIWidget-ColorPicker.lua:57>
[string "@ElvUI/Core/Modules/Blizzard/ColorPicker.lua"]:110: in function <...eElvUI/Core/Modules/Blizzard/ColorPicker.lua:108>

Locals:
(*temporary) = Texture {
 0 = <userdata>
 PixelSnapDisabled = true
}
(*temporary) = "HORIZONTAL"
(*temporary) = <table> {
 a = 1
 GetRGB = <function> defined @SharedXML/Color.lua:21
 OnLoad = <function> defined @SharedXML/Color.lua:10
 GenerateHexColorMarkup = <function> defined @SharedXML/Color.lua:52
 WrapTextInColorCode = <function> defined @SharedXML/Color.lua:56
 GenerateHexColor = <function> defined @SharedXML/Color.lua:48
 GetRGBA = <function> defined @SharedXML/Color.lua:29
 IsEqualTo = <function> defined @SharedXML/Color.lua:14
 SetRGBA = <function> defined @SharedXML/Color.lua:37
 GetRGBAsBytes = <function> defined @SharedXML/Color.lua:25
 SetRGB = <function> defined @SharedXML/Color.lua:44
 GetRGBAAsBytes = <function> defined @SharedXML/Color.lua:33
}
(*temporary) = <table> {
 a = 1
 GetRGB = <function> defined @SharedXML/Color.lua:21
 OnLoad = <function> defined @SharedXML/Color.lua:10
 GenerateHexColorMarkup = <function> defined @SharedXML/Color.lua:52
 WrapTextInColorCode = <function> defined @SharedXML/Color.lua:56
 GenerateHexColor = <function> defined @SharedXML/Color.lua:48
 GetRGBA = <function> defined @SharedXML/Color.lua:29
 IsEqualTo = <function> defined @SharedXML/Color.lua:14
 SetRGBA = <function> defined @SharedXML/Color.lua:37
 GetRGBAsBytes = <function> defined @SharedXML/Color.lua:25
 SetRGB = <function> defined @SharedXML/Color.lua:44
 GetRGBAAsBytes = <function> defined @SharedXML/Color.lua:33
}

358x ElvUI_ToxiUI/Core/Functions/Core.lua:114: attempt to perform arithmetic on local 'a' (a nil value)
[string "@ElvUI_ToxiUI/Core/Functions/Core.lua"]:114: in function `AlmostEqual'
[string "@ElvUI_ToxiUI/Core/Functions/Color.lua"]:10: in function `EqualToRGB'
[string "@ElvUI_ToxiUI/Modules/Themes/Gradients/Update.lua"]:13: in function `SetGradientColors'
[string "@ElvUI_ToxiUI/Modules/Themes/Gradients/Health.lua"]:58: in function <...Ons/ElvUI_ToxiUI/Modules/Themes/Gradients/Health.lua:42>
[string "=(tail call)"]: ?
[string "=(tail call)"]: ?
[string "@ElvUI_Libraries/Core/oUF/elements/health.lua"]:139: in function <ElvUI_Libraries/Core/oUF/elements/health.lua:86>
[string "@ElvUI_Libraries/Core/oUF/elements/health.lua"]:151: in function <ElvUI_Libraries/Core/oUF/elements/health.lua:143>
[string "@ElvUI_Libraries/Core/oUF/elements/health.lua"]:205: in function `func'
[string "@ElvUI_Libraries/Core/oUF/ouf.lua"]:238: in function <ElvUI_Libraries/Core/oUF/ouf.lua:221>
[string "=(tail call)"]: ?
[string "@ElvUI_Libraries/Core/oUF/ouf.lua"]:256: in function <ElvUI_Libraries/Core/oUF/ouf.lua:255>
[string "=[C]"]: in function `Show'
[string "@FrameXML/SecureStateDriver.lua"]:83: in function <FrameXML/SecureStateDriver.lua:73>
[string "@FrameXML/SecureStateDriver.lua"]:137: in function <FrameXML/SecureStateDriver.lua:119>

Locals:
a = nil
b = 0.250000
(*temporary) = <function> defined =[C]:-1
(*temporary) = nil
(*temporary) = "attempt to perform arithmetic on local 'a' (a nil value)"
abs = <function> defined =[C]:-1

Share to

Description

Screenshots

Acceptance criteria