Describe the Bug

I will start off by saying that I am a Modpack Developer and currently developing the 1.18.2 update for my Modpack Vanilla Plus by Cama.

Our team agreed that the mod Mining Master is a really good mod to have installed on our pack since Apotheosis makes End Game Enchanting a thing and to balance that out, we re-work Start Game Enchanting (your mod).

We are currently in the Server Testing portion of our mod and found out that, when a player applies an ability to an item (Frost on Sword or Smelting on a Pickaxe), that effect is applied for every single player Globally and it works if they use their fist.

This is extremely game-breaking, and causes a lot of issues as you can probably tell. Every single player has access to the abilities that are only supposed to be specific to one item.

Not only does this affect players, but any sort of mod that adds things that interact with the world as though players do. CREATE MOD for example will drop smelted items instead of the normal drop if just one player has a smelting thing on their pickaxe.

I have no clue how to reproduce this bug, I am providing a link to download my MODPACK in the form of a ZIP file used on CurseForge and a link to download the SERVER FILES for my MODPACK. I will include LOGS (Debug and Normal). There is no crash report so I cannot send that. In order to find this bug, you will have to actually open a server.

I apologize that I cannot help or provide any further information. This is all I got. I don't know if there are any mod conflicts either.

Also, I wanted to point out that you have not updated the drop-down for version selection on GitHub. I put the current version in the TITLE of this BUG REPORT.

Reproduction Steps

1. Join a multiplayer server on my modpack

Expected Result

1. Special Enchanted Abilities on Items should be specific to the ITEM and NOT GLOBAL FOR EVERY PLAYER

Screenshots and Videos

No screenshots or Videos.

Operating System

Windows 10

Mod Version

2.1.0

Minecraft Version

1.16.5

Forge Version

40.1.73

Other Mods

Additional Context

SERVER LOG FILES

latest.log
debug.log

MODPACK ZIP FOR CURSEFORGE:
VP DEV-2.09.1.zip

COMPLETE WORKING SERVER FILES: https://drive.google.com/file/d/1UAiLsCdOPLhP9SS_BMSaSYwFLjuwxyC0/view?usp=sharing

Hey there, thanks for the comprehensive bug report!
If you wouldn't mind doing additional tests: Could you consider taking out every other enchanting-related mod in the modpack and seeing if this effect still happens? Narrowing down the issue/conflict to another mod would help a lot!

I can definitely try that tomorrow. I have been working my a** off on this modpack and I hate testing a series of mods but it will help you and also help us. I can work on this tomorrow!

I really appreciate it! My theory is that there’s something off with the loot modifier, but I have honestly no idea what should cause it. The loot modifier should only apply if the block is being mined with a tool with the enchantment, so no idea why it would check ALL players on the server for that enchantment. I probably won’t be able to take a look until end of this week or early next week, but I’ll do my best to get to it ASAP!

I tried disabling Enchantment Mods but I wasn't getting any results. I'm sorry that I couldn't be more help. Hopefully, you guys can figure this one out!

Of course! Thank you for testing that out!

I'm curious, based on your initial report, I don't understand how this could happen in single-player. Could you elaborate on how this bug shows itself in single-player?

Upon further testing, it seems that the bug is entirely random. There were times in a single-player world where the issue occurred and other times it didn't. This makes troubleshooting extremely difficult :\

Next time it happens, I will send logs.

Apologies for the late response. I will do some more testing and see if I can re-produce this bug again. It's happening at random it seems.

Very interesting. I'll also have to do some research into how Forge handles their loot table modifiers.

I haven't noticed this issue in newer updates. It may have been a conflict with another mod.

Experiencing this in 1.19.2. Applied Grace V to a chestplate and now any entity (including mobs) that touches water receives the Dolphin's grace effect for 30 seconds, even after the offending piece of armor has been destroyed.

Here's a spark readout from my testing which includes a full list of involved mods: https://spark.lucko.me/ruH0bM5ND8
Specifically, I'm running this modpack: https://www.curseforge.com/minecraft/modpacks/grindergard-revolution

I can't imagine why there would be even a player-level flag getting set for this, but I'll try to dig around with NBTExplorer in the world save and see if there's something in the world or player data related to this as that's the only other thing I can think to check.

Update: Restarting the server ends the bug, but it crops up on an enchant-by-enchant basis. The first time silk touch was applied to a tool using spider kunzite, all blocks began dropping themselves when broken with a bare hand or with breakage like leaf decay. I haven't had a chance to test extensively yet, but it appears to be tied to the first time an enchant is applied rather than every time.

I have pretty good reason to believe that this was actually tied to the same issue as #49. I've resolved that for the next version that will be released. I'm going to close this issue for now as resolved. If the issue persists in the next Mining Master release, please feel free to reopen this issue. Given that it's so hard to test this bug since it shows up so sporadically, it's hard to say. But your info about it happening when enchanting (I'm assuming using the gems in a smithing table, given the issue I discovered) seems to point to the bug I just resolved.

Interesting... thank you for these updates! I'm in a bug-fixing grind for MM right now, so I'll look into this a bit!